public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters
Date: Mon, 18 Jun 2012 16:23:34 +0200	[thread overview]
Message-ID: <201206181623.34836.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5C-dVtDh_5AJ9BOfdnB2Eyo5aQTNgvOzR4txnAYiTsYdw@mail.gmail.com>

Dear Fabio Estevam,

> Hi Marek,
> 
> On Thu, May 31, 2012 at 3:45 PM, Marek Vasut <marex@denx.de> wrote:
> > Call this or similar in your spl_boot.c to adjust the DRAM configuration.
> > Actually I think even the following value should fix your problem:
> > 
> > void mx28_adjust_memory_params(uint32_t *dram_vals)
> > {
> >        dram_vals[0x74 >> 2] = 0x0f02010a;
> > }
> 
> I finally had a chance to try this and my mx28evk can boot again with
> your patch + the code above.
> 
> How do we handle this? Would you send a v2 with this additional code
> or should I do it myself after your original patch in this thread gets
> applied?

Stefano, can you please apply this? So Fabio can apply his on top of it?

> Also, please explain to the mortal folks what 'dram_vals[0x74 >> 2] =
> 0x0f02010a;' means.

Well, check that particular register (memory configuration register at +0x74 
offset) in the datasheet. It's basically adjusting the number of enabled address 
row and columns.

> It is not something very trivial to figure out :-)

It actually is, see above ;-)

> Thanks,
> 
> Fabio Estevam

Best regards,
Marek Vasut

  reply	other threads:[~2012-06-18 14:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  5:43 [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters Marek Vasut
2012-05-31 18:04 ` Fabio Estevam
2012-05-31 18:45   ` Marek Vasut
2012-06-18 14:17     ` Fabio Estevam
2012-06-18 14:23       ` Marek Vasut [this message]
2012-06-18 15:16         ` Stefano Babic
2012-06-18 15:36           ` Marek Vasut
2012-06-18 15:43             ` Marek Vasut
2012-06-18 16:32               ` Stefano Babic
2012-06-18 17:10                 ` Marek Vasut
2012-06-19  7:29 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206181623.34836.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox