From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register
Date: Tue, 19 Jun 2012 23:12:34 +0200 [thread overview]
Message-ID: <201206192312.34848.marex@denx.de> (raw)
In-Reply-To: <1340126696-29673-1-git-send-email-fabio.estevam@freescale.com>
Dear Fabio Estevam,
> commit acc4959fc1 (Revert "i.MX28: Enable additional DRAM address bits")
> broke mx28evk boot.
>
> Fix it by properly adjusting the HW_DRAM_CTL29 register value.
>
> Suggested-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/mx28evk/iomux.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/board/freescale/mx28evk/iomux.c
Uh, why isn't this file called splboot.c?
But
Acked-by: Marek Vasut <marex@denx.de>
> b/board/freescale/mx28evk/iomux.c index 6587c45..1e60204 100644
> --- a/board/freescale/mx28evk/iomux.c
> +++ b/board/freescale/mx28evk/iomux.c
> @@ -161,6 +161,20 @@ const iomux_cfg_t iomux_setup[] = {
> (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
> };
>
> +#define HW_DRAM_CTL29 (0x74 >> 2)
> +#define CS_MAP 0xf
> +#define COLUMN_SIZE 0x2
> +#define ADDR_PINS 0x1
> +#define APREBIT 0xa
> +
> +#define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
> + ADDR_PINS << 8 | APREBIT)
> +
> +void mx28_adjust_memory_params(uint32_t *dram_vals)
> +{
> + dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
> +}
> +
> void board_init_ll(void)
> {
> mx28_common_spl_init(iomux_setup, ARRAY_SIZE(iomux_setup));
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-06-19 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 17:24 [U-Boot] [PATCH] mx28evk: Fix boot by adjusting HW_DRAM_CTL29 register Fabio Estevam
2012-06-19 21:12 ` Marek Vasut [this message]
2012-06-27 13:17 ` Fabio Estevam
2012-07-02 17:51 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206192312.34848.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox