From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 22 Jun 2012 09:01:07 +0200
Subject: [U-Boot] [PATCH 2/3] AM335x : Configs to add USB host support.
In-Reply-To: <1340345836-23694-3-git-send-email-harman_sohanpal@ti.com>
References: <1340345836-23694-1-git-send-email-harman_sohanpal@ti.com>
	<1340345836-23694-3-git-send-email-harman_sohanpal@ti.com>
Message-ID: <201206220901.07701.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday 22 June 2012 08:17:15 Harman Sohanpal wrote:
> This patch adds required configs in config file for
> am335x_evm to add support for usb host mode.
> To enable USB device mode, add CONFIG_MUSB_UDC in
> place of CONFIG_MUSB_HCD
> 
> Signed-off-by: Harman Sohanpal <harman_sohanpal@ti.com>
> ---
>  include/configs/am335x_evm.h |   41
> +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 41
> insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
> index d0fbc88..d19f914 100644
> --- a/include/configs/am335x_evm.h
> +++ b/include/configs/am335x_evm.h
> @@ -165,6 +165,47 @@
>  #define CONFIG_SKIP_LOWLEVEL_INIT
>  #endif
> 
> +
> +/*
> + * USB configuration
> + * Enable CONFIG_MUSB_HCD for Host functionalities MSC, keyboard
> + * Enable CONFIG_MUSB_UDC for Device functionalities.
> + */
> +#define CONFIG_USB_AM335X                1
> +#define CONFIG_MUSB_HCD                 1

Please don't add the "1" to the defines. Simply define the value, thats 
enough.

> +
> +#ifdef CONFIG_USB_AM335X
> +
> +#ifdef CONFIG_MUSB_HCD
> +#define CONFIG_CMD_USB
> +
> +#define CONFIG_USB_STORAGE
> +#define CONGIG_CMD_STORAGE
> +#define CONFIG_CMD_FAT
> +
> +#ifdef CONFIG_USB_KEYBOARD
> +#define CONFIG_SYS_USB_EVENT_POLL
> +#define CONFIG_PREBOOT "usb start"
> +#endif /* CONFIG_USB_KEYBOARD */
> +
> +#endif /* CONFIG_MUSB_HCD */
> +
> +#ifdef CONFIG_MUSB_UDC
> +/* USB device configuration */
> +#ifndef CONFIG_SPL_BUILD
> +#define CONFIG_USB_DEVICE               1
> +#define CONFIG_USB_TTY                  1
> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV    1

Here again. No "1" please.

Thanks,
Stefan