From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Fri, 22 Jun 2012 11:43:59 -0700 Subject: [U-Boot] [PATCH v4 02/13] tegra20: move tegra20 SoC code to arch/arm/cpu/tegra20-common In-Reply-To: <4FE4B65B.3050702@wwwdotorg.org> References: <1340323247-15512-1-git-send-email-amartin@nvidia.com> <1340323247-15512-3-git-send-email-amartin@nvidia.com> <4FE4B65B.3050702@wwwdotorg.org> Message-ID: <20120622184359.GB17621@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 22, 2012 at 11:15:55AM -0700, Stephen Warren wrote: > On 06/21/2012 06:00 PM, Allen Martin wrote: > > In preparation for splitting out the armv4t code from tegra20, move > > the tegra20 SoC code to arch/arm/cpu/tegra20-common. This code will > > be compiled armv4t for the arm7tdmi and armv7 for the cortex A9. > > > > Signed-off-by: Allen Martin > > The only thing I wonder here is whether tegra20-common or tegra-common > is a better location, given that we'll eventually add Tegra30 support, > and some of the code might be shared. > > Still, we can address that issue when we add Tegra30 support I think, so. > > Acked-by: Stephen Warren I think Simon had the same feedback in a earlier version. My response was that pulling out the tegra20/tegra30 commonalities will require much more refactoring and is better left to a separate patch series. -Allen -- nvpublic