From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 22 Jun 2012 19:02:43 +0200 Subject: [U-Boot] [PATCH 08/24] mxc_i2c: remove redundant read In-Reply-To: <1340338339-11626-8-git-send-email-troy.kisky@boundarydevices.com> References: <1340338339-11626-1-git-send-email-troy.kisky@boundarydevices.com> <1340338339-11626-8-git-send-email-troy.kisky@boundarydevices.com> Message-ID: <201206221902.44047.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Troy Kisky, > wait_for_sr_state returns i2sr on success > so no need to read again. > > Signed-off-by: Troy Kisky Acked-by: Marek Vasut > --- > drivers/i2c/mxc_i2c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c > index 7b1b75c..9063d1e 100644 > --- a/drivers/i2c/mxc_i2c.c > +++ b/drivers/i2c/mxc_i2c.c > @@ -193,7 +193,6 @@ static int tx_byte(struct mxc_i2c_regs *i2c_regs, u8 > byte) ret = wait_for_sr_state(i2c_regs, ST_IIF); > if (ret < 0) > return ret; > - ret = readb(&i2c_regs->i2sr); > if (ret & I2SR_RX_NO_AK) > return -ENODEV; > return 0; Best regards, Marek Vasut