From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 24 Jun 2012 09:53:20 +0200 Subject: [U-Boot] [PATCH 2/4] mx53loco: add a comment about local copy of print_cpuinfo method In-Reply-To: <1340482108-18468-2-git-send-email-otavio@ossystems.com.br> References: <1340482108-18468-1-git-send-email-otavio@ossystems.com.br> <1340482108-18468-2-git-send-email-otavio@ossystems.com.br> Message-ID: <20120624075320.9147D2000ED@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, In message <1340482108-18468-2-git-send-email-otavio@ossystems.com.br> you wrote: > Signed-off-by: Otavio Salvador > Cc: Marek Vasut > Cc: Stefano Babic > Cc: Fabio Estevam > --- > board/freescale/mx53loco/mx53loco.c | 2 ++ > 1 file changed, 2 insertions(+) Argh!!! Plese read http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions Please mark updated versions of a patch in the Subject:, and include a change log. > +/* Needs to be available on the board file to be called in board_init, > + * instead of normal order */ This cmment makes no sense to me. Also, this is incorrect multi-line comment style. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de First study the enemy. Seek weakness. -- Romulan Commander, "Balance of Terror", stardate 1709.2