From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 24 Jun 2012 09:55:48 +0200 Subject: [U-Boot] [PATCH 2/4] mx53loco: Add a comment about local print_cpuinfo method in board file In-Reply-To: <1340482108-18468-3-git-send-email-otavio@ossystems.com.br> References: <1340482108-18468-1-git-send-email-otavio@ossystems.com.br> <1340482108-18468-3-git-send-email-otavio@ossystems.com.br> Message-ID: <20120624075548.3EF052000ED@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, In message <1340482108-18468-3-git-send-email-otavio@ossystems.com.br> you wrote: > Signed-off-by: Otavio Salvador > Cc: Marek Vasut > Cc: Stefano Babic > Cc: Fabio Estevam > --- > board/freescale/mx53loco/mx53loco.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c > index 445d022..5df1b18 100644 > --- a/board/freescale/mx53loco/mx53loco.c > +++ b/board/freescale/mx53loco/mx53loco.c > @@ -413,6 +413,11 @@ int board_early_init_f(void) > return 0; > } > > +/* > + * Usually this is called too early printing a wrong information about > + * the clock. To fix it we need to provide this local method and call > + * it later in board_init. > + */ I don't like this change. It messes with the initialization sequence, which is not a good thing. Instead of shift more and more things backwards, we should fix any incorrect clock calculations here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A star captain's most solemn oath is that he will give his life, even his entire crew, rather than violate the Prime Directive. -- Kirk, "The Omega Glory", stardate unknown