From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 24 Jun 2012 15:08:42 +0200
Subject: [U-Boot] [PATCH 3/4] imx: Use a clear identification of an
	unidentified CPU type
In-Reply-To: <20120624065706.ABD192000ED@gemini.denx.de>
References: <1340482108-18468-1-git-send-email-otavio@ossystems.com.br>
	<1340482108-18468-4-git-send-email-otavio@ossystems.com.br>
	<20120624065706.ABD192000ED@gemini.denx.de>
Message-ID: <201206241508.42858.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Otavio Salvador,
> 
> In message <1340482108-18468-4-git-send-email-otavio@ossystems.com.br> you 
wrote:
> > In case an unidentified CPU type is detected it now returns
> > i.MX<unidentified>, in a const char.
> 
> ...
> 
> > -static char *get_imx_type(u32 imxtype)
> > +static const char *get_imx_type(u32 imxtype)
> 
> I agree with the const change.
> 
> > -		return "unknown";
> > +		return "<unidentified>";
> 
> But in which way would "<unidentified>" be better than "unknown"?  It
> just costs 7 more bytes of memory...

"i.MXunknown" is much more weird than "i.MX<unidentified>" . This is on my tap, 
Otavio is innocent with this one. btw. this would be static data, so adding 7 
more bytes won't hurt anyone.

> Please drop this change.
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut