From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 27 Jun 2012 10:40:15 -0700 Subject: [U-Boot] [PATCH] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0 In-Reply-To: <4FE85CB5.6070505@kmckk.co.jp> References: <4FE85CB5.6070505@kmckk.co.jp> Message-ID: <20120627174015.GC28055@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jun 25, 2012 at 09:42:29PM +0900, Tetsuyuki Kobayashi wrote: > save_boot_params_default() in cpu.c accesses uninitialized stack area > when it compiled with -O0 (not optimized). > > Signed-off-by: Tetsuyuki Kobayashi > --- > arch/arm/cpu/armv7/cpu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c > index c6fa8ef..6104cb2 100644 > --- a/arch/arm/cpu/armv7/cpu.c > +++ b/arch/arm/cpu/armv7/cpu.c > @@ -37,8 +37,11 @@ > #include > #include > > +__attribute__((naked)) /* don't save anything to stack even if compiled with -O0 */ > void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3) > { > + /* stack is not yet initialized */ > + asm("bx lr"); > } Please add and use __naked instead. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: