public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] EXT2: Indent cleanup ext2fs.c
Date: Fri, 29 Jun 2012 00:03:34 +0200	[thread overview]
Message-ID: <201206290003.35097.marex@denx.de> (raw)
In-Reply-To: <20120628194833.GK3112@titan.lakedaemon.net>

Dear Jason Cooper,

> On Fri, Jun 08, 2012 at 07:31:47PM +0200, Marek Vasut wrote:
> > * Mostly cleanup problems reported by checkpatch.pl -f
> > * Minor tweaks where it simplified the code
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> > 
> >  fs/ext2/ext2fs.c |  264
> >  ++++++++++++++++++++++++++---------------------------- 1 file changed,
> >  128 insertions(+), 136 deletions(-)
> > 
> > diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c
> > index a4f3094..f9e9228 100644
> > --- a/fs/ext2/ext2fs.c
> > +++ b/fs/ext2/ext2fs.c
> > @@ -27,12 +27,11 @@
> > 
> >  #include <ext2fs.h>
> >  #include <ext_common.h>
> >  #include <malloc.h>
> > 
> > -#include <asm/byteorder.h>
> > +#include <linux/byteorder/generic.h>
> > 
> > -extern int ext2fs_devread (int sector, int byte_offset, int byte_len,
> > +extern int ext2fs_devread(int sector, int byte_offset, int byte_len,
> > 
> >  			   char *buf);
> > 
> > -
> 
> This is not applying to origin/master.  It has:
> 
> /* Magic value used to identify an ext2 filesystem.  */
> #define EXT2_MAGIC              0xEF53
> /* Amount of indirect blocks in an inode.  */
> #define INDIRECT_BLOCKS         12
> /* Maximum lenght of a pathname.  */
> #define EXT2_PATH_MAX           4096
> /* Maximum nesting of symlinks, used to prevent a loop.  */
> #define EXT2_MAX_SYMLINKCNT     8
> 
> at line 33, 32 after.  a git blame for these lines shows only 2b918712
> which is from 2004.  What is this based on?  a4f3094 isn't in my tree...
> 
> thx,

Ok, I'll go through it and let you know soon. I hope about next week. Do you 
might hacking on something else in the meantime, don't waste your time here 
please until I look through it.

> Jason.
[...]

  reply	other threads:[~2012-06-28 22:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 17:31 [U-Boot] [PATCH 0/8] EXT2 cleanup Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 1/8] EXT2: Indent cleanup of dev.c Marek Vasut
2012-08-09 20:01   ` Wolfgang Denk
2012-06-08 17:31 ` [U-Boot] [PATCH 2/8] EXT2: Indent cleanup ext2fs.c Marek Vasut
2012-06-28 19:48   ` Jason Cooper
2012-06-28 22:03     ` Marek Vasut [this message]
2012-08-09 20:02   ` Wolfgang Denk
2012-06-08 17:31 ` [U-Boot] [PATCH 3/8] EXT2: Rework ext2fs_blockgroup() function Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 4/8] EXT2: Rework ext2fs_read_file() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 5/8] EXT2: Rework ext2fs_read_symlink() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 6/8] EXT2: Rework ext2fs_find_file1() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 7/8] EXT2: Rework ext2fs_iterate_dir() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 8/8] EXT2: Rework ext2fs_read_block() Marek Vasut
2012-06-09  5:48 ` [U-Boot] [PATCH 0/8] EXT2 cleanup Jorgen Lundman
2012-06-09 10:38   ` Marek Vasut
2012-06-09 17:52 ` Jason Cooper
2012-06-09 17:55   ` Marek Vasut
2012-06-17 15:12 ` Marek Vasut
2012-06-28 13:52   ` Jason Cooper
2012-06-28 14:35     ` Marek Vasut
2012-06-28 14:48       ` Jason Cooper
2012-06-28 14:50         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206290003.35097.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox