[U-Boot] [PATCH 2/8] EXT2: Indent cleanup ext2fs.c

Marek Vasut
2012-06-28T22:03:34Z

Dear Jason Cooper,

> On Fri, Jun 08, 2012 at 07:31:47PM +0200, Marek Vasut wrote:
> > * Mostly cleanup problems reported by checkpatch.pl -f
> > * Minor tweaks where it simplified the code
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> >
> > fs/ext2/ext2fs.c | 264
> > ++++++++++++++++++++++++++---------------------------- 1 file changed,
> > 128 insertions(+), 136 deletions(-)
> >
> > diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c
> > index a4f3094..f9e9228 100644
> > --- a/fs/ext2/ext2fs.c
> > +++ b/fs/ext2/ext2fs.c
> > @@ -27,12 +27,11 @@
> >
> > #include <ext2fs.h>
> > #include <ext_common.h>
> > #include <malloc.h>
> >
> > -#include <asm/byteorder.h>
> > +#include <linux/byteorder/generic.h>
> >
> > -extern int ext2fs_devread (int sector, int byte_offset, int byte_len,
> > +extern int ext2fs_devread(int sector, int byte_offset, int byte_len,
> >
> > char *buf);
> >
> > -
>
> This is not applying to origin/master. It has:
>
> /* Magic value used to identify an ext2 filesystem. */
> #define EXT2_MAGIC 0xEF53
> /* Amount of indirect blocks in an inode. */
> #define INDIRECT_BLOCKS 12
> /* Maximum lenght of a pathname. */
> #define EXT2_PATH_MAX 4096
> /* Maximum nesting of symlinks, used to prevent a loop. */
> #define EXT2_MAX_SYMLINKCNT 8
>
> at line 33, 32 after. a git blame for these lines shows only 2b918712
> which is from 2004. What is this based on? a4f3094 isn't in my tree...
>
> thx,

Ok, I'll go through it and let you know soon. I hope about next week. Do you
might hacking on something else in the meantime, don't waste your time here
please until I look through it.

> Jason. …