[U-Boot] [PATCH 1/4] ehci-omap: Do not call dcache_off from omap_ehci_hcd_init

Marek Vasut
2012-06-14T21:57:32Z

Dear Tom Rini,

> This has never been completely sufficient and now happens too late to
> paper over the cache coherency problems with the current USB stack.

Poor USB maintainer isn't CCed :'-(

>
> Signed-off-by: Tom Rini <trini@ti.com>

But this is always a good thing to see.

Acked-by: Marek Vasut <marex@denx.de>

> ---
> drivers/usb/host/ehci-omap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 1ed7710..292673b 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -246,7 +246,6 @@ int omap_ehci_hcd_init(struct omap_usbhs_board_data
> *usbhs_pdata) if (is_ehci_phy_mode(usbhs_pdata->port_mode[i]))
> omap_ehci_soft_phy_reset(i);
>
> - dcache_disable();
> hccr = (struct ehci_hccr *)(OMAP_EHCI_BASE);
> hcor = (struct ehci_hcor *)(OMAP_EHCI_BASE + 0x10);

Best regards,
Marek Vasut