From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/6] mcx: Disable DCACHE since USB EHCI is enabled
Date: Wed, 4 Jul 2012 02:14:37 +0200 [thread overview]
Message-ID: <201207040214.38072.marex@denx.de> (raw)
In-Reply-To: <4FF3602B.6070102@emcraft.com>
Dear Ilya Yanok,
> Hi Tom,
>
> 04.07.2012 00:43, Tom Rini wrote:
> > On 07/03/2012 01:13 PM, Ilya Yanok wrote:
> >> Dear Marek,
> >>
> >> 30.06.2012 23:28, Marek Vasut wrote:
> >>>> Not exactly. It never worked (at least on my systems) with D-Cache
> >>>> enabled. But at least we had a choice of run-time disabled dcache.
> >>>> With the recent changes we have to disable cache support at compile
> >>>> time.
> >>>
> >>> I see what you're after. But do you consider runtime disabling the
> >>> cache is the
> >>> way to go or it's a way of hiding bugs?
> >>
> >> Both ;) And now we are going to hide even more bugs with compile-time
> >> disabling :(
> >
> > Does someone wish to argue we should disable USB support instead on
> > these platforms? I don't see anyone arguing "I have time to fix this
> > for v2012.07".
>
> I just looked at the code more carefully and it seems that most of the
> upper layers are in much better shape than I thought. So I think we
> should just extend your 2/6 patch to fix both address and size for
> structs QH and qtd and don't mess with buffer at all: if we got
> unaligned buffer -- it's definetely upper layer bug so we should produce
> some noise in this case. As I said upper layers seems to be in good
> shape so hopefully there won't be too much noise.
>
> Hm, probably we should put buffer invalidation under
> if(dcache_enabled()) to leave run-time cache disabling as rescue option
> for broken upper-layer code..
>
> I'm working on the patch now and hopefully will post it this night.
Ilya, thank you for saving my back ;-)
And thank you for investing your time into this.
> Regards, Ilya.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-04 0:14 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 19:01 [U-Boot] [PATCH 0/4] USB and cache related fixes Tom Rini
2012-06-14 19:01 ` [U-Boot] [PATCH 1/4] ehci-omap: Do not call dcache_off from omap_ehci_hcd_init Tom Rini
2012-06-14 21:57 ` Marek Vasut
2012-06-14 22:14 ` Tom Rini
2012-06-14 19:01 ` [U-Boot] [PATCH 2/4] cache_v7: Check for dcache enablement in dcache flush functions Tom Rini
2012-06-14 22:00 ` Marek Vasut
2012-06-14 22:11 ` Tom Rini
2012-06-14 23:17 ` Marek Vasut
2012-06-15 5:48 ` R, Sricharan
2012-06-15 14:07 ` Tom Rini
2012-06-15 14:25 ` Marek Vasut
2012-06-15 14:30 ` Tom Rini
2012-06-15 14:33 ` Marek Vasut
2012-06-15 14:48 ` R, Sricharan
2012-06-15 15:00 ` Tom Rini
2012-06-15 15:18 ` R, Sricharan
2012-06-15 15:20 ` Tom Rini
2012-06-18 14:13 ` R, Sricharan
2012-06-18 15:23 ` Tom Rini
2012-06-20 16:46 ` Aneesh V
2012-06-21 9:25 ` Sricharan R
2012-06-21 15:23 ` R, Sricharan
2012-06-27 23:40 ` Aneesh V
2012-06-28 5:49 ` R, Sricharan
2012-06-27 23:17 ` Aneesh V
2012-06-14 19:01 ` [U-Boot] [PATCH 3/4] ehci-hcd.c: Add a new USB_DMA_MINALIGN define for cache alignment Tom Rini
2012-06-14 19:29 ` Marek Vasut
2012-06-14 19:30 ` Tom Rini
2012-06-14 19:41 ` Marek Vasut
2012-06-14 19:54 ` Tom Rini
2012-06-14 20:02 ` Marek Vasut
2012-06-14 19:01 ` [U-Boot] [PATCH 4/4] musb_core.h: " Tom Rini
2012-06-14 21:45 ` [U-Boot] [PATCH v2 0/3] USB and cache related fixes Tom Rini
2012-06-14 21:45 ` [U-Boot] [PATCH v2 1/3] ehci-omap: Do not call dcache_off from omap_ehci_hcd_init Tom Rini
2012-06-14 21:45 ` [U-Boot] [PATCH v2 2/3] cache_v7: Check for dcache enablement in dcache flush functions Tom Rini
2012-06-14 21:45 ` [U-Boot] [PATCH v2 3/3] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Tom Rini
2012-06-20 16:21 ` [U-Boot] [PATCH v3 0/6] USB and cache related fixes Tom Rini
2012-06-20 16:21 ` [U-Boot] [PATCH v3 1/6] ehci-omap: Do not call dcache_off from omap_ehci_hcd_init Tom Rini
2012-06-20 16:21 ` [U-Boot] [PATCH v3 2/6] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Tom Rini
2012-06-20 19:00 ` Marek Vasut
2012-06-20 19:15 ` Tom Rini
2012-06-20 21:15 ` Marek Vasut
2012-06-20 22:07 ` Tom Rini
2012-06-21 0:09 ` Marek Vasut
2012-06-20 16:21 ` [U-Boot] [PATCH v3 3/6] mcx: Disable DCACHE since USB EHCI is enabled Tom Rini
2012-06-20 16:21 ` [U-Boot] [PATCH v3 4/6] omap3_beagle: " Tom Rini
2012-06-20 16:21 ` [U-Boot] [PATCH v3 5/6] omap4_panda: " Tom Rini
2012-06-20 16:21 ` [U-Boot] [PATCH v3 6/6] tam3517-common: " Tom Rini
2012-06-20 22:14 ` [U-Boot] [PATCH v4 0/6] USB and cache related fixes Tom Rini
2012-06-20 22:14 ` [U-Boot] [PATCH v4 1/6] ehci-omap: Do not call dcache_off from omap_ehci_hcd_init Tom Rini
2012-06-20 22:14 ` [U-Boot] [PATCH v4 2/6] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Tom Rini
2012-06-20 22:14 ` [U-Boot] [PATCH v4 3/6] mcx: Disable DCACHE since USB EHCI is enabled Tom Rini
2012-06-27 22:28 ` Ilya Yanok
2012-06-27 22:48 ` Marek Vasut
2012-06-28 13:57 ` Ilya Yanok
2012-06-28 14:37 ` Marek Vasut
2012-06-28 14:57 ` Ilya Yanok
2012-06-28 15:41 ` Marek Vasut
2012-06-30 15:51 ` Ilya Yanok
2012-06-30 19:27 ` Marek Vasut
2012-07-03 20:10 ` Ilya Yanok
2012-07-03 21:23 ` Marek Vasut
2012-06-28 17:29 ` Tom Rini
2012-06-28 22:01 ` Marek Vasut
2012-06-28 22:34 ` Tom Rini
2012-06-28 22:36 ` Marek Vasut
2012-06-28 23:01 ` Tom Rini
2012-06-29 0:54 ` Marek Vasut
2012-06-29 2:14 ` Tom Rini
2012-06-30 15:55 ` Ilya Yanok
2012-06-30 19:28 ` Marek Vasut
2012-07-03 20:13 ` Ilya Yanok
2012-07-03 20:43 ` Tom Rini
2012-07-03 21:12 ` Ilya Yanok
2012-07-04 0:14 ` Marek Vasut [this message]
2012-07-04 13:08 ` Ilya Yanok
2012-07-03 21:24 ` Marek Vasut
2012-06-20 22:14 ` [U-Boot] [PATCH v4 4/6] omap3_beagle: " Tom Rini
2012-06-20 22:14 ` [U-Boot] [PATCH v4 5/6] omap4_panda: " Tom Rini
2012-06-21 11:19 ` Sricharan R
2012-06-21 16:40 ` R, Sricharan
2012-06-20 22:14 ` [U-Boot] [PATCH v4 6/6] tam3517-common: " Tom Rini
2012-06-14 22:02 ` [U-Boot] [PATCH 0/4] USB and cache related fixes Marek Vasut
2012-06-14 22:13 ` Tom Rini
2012-06-14 23:17 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207040214.38072.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox