public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Remove unused CONFIG_STACKSIZE
Date: Thu, 5 Jul 2012 12:10:14 +0200	[thread overview]
Message-ID: <20120705121014.2b097e23@aari01-12> (raw)
In-Reply-To: <1340891651-17618-1-git-send-email-robherring2@gmail.com>

Hi Rob,

On Thu, 28 Jun 2012 08:54:10 -0500, Rob Herring <robherring2@gmail.com>
wrote:
> From: Rob Herring <rob.herring@calxeda.com>
> 
> CONFIG_STACKSIZE is not referenced anywhere except on AVR32, but
> present in most ARM boards. The IRQ and FIQ stacks are not setup in
> start.S, but arch/arm/lib/board.c, so also remove those comments.

Not sure I understand the last point. Can you clarify? How does this
relate to keeping FIQ / IRQ stack size declarations in config files?
E.g.:

> diff --git a/include/configs/SX1.h b/include/configs/SX1.h
> index ea09368..1c4f305 100644
> --- a/include/configs/SX1.h
> +++ b/include/configs/SX1.h
> @@ -141,10 +141,7 @@
>  
>  /*-----------------------------------------------------------------------
>   * Stack sizes
> - *
> - * The stack sizes are set up in start.S using the settings below
>   */
> -#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
>  #ifdef CONFIG_USE_IRQ
>  #define CONFIG_STACKSIZE_IRQ	(4*1024)	/* IRQ stack */
>  #define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */

These are kept, which seems to not match or explain the commit msg.

Amicalement,
-- 
Albert.

  reply	other threads:[~2012-07-05 10:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 13:54 [U-Boot] [PATCH 1/2] Remove unused CONFIG_STACKSIZE Rob Herring
2012-07-05 10:10 ` Albert ARIBAUD [this message]
2012-07-05 21:31   ` Rob Herring
2012-07-06 11:17     ` Albert ARIBAUD
2012-07-13 19:44 ` [U-Boot] [PATCH v2] ARM: Remove unused stack and irq config defines Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120705121014.2b097e23@aari01-12 \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox