public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] kirkwood: implement kw_sdram_bs_set()
Date: Thu, 5 Jul 2012 17:51:52 +0200	[thread overview]
Message-ID: <201207051751.52434.marex@denx.de> (raw)
In-Reply-To: <4FF5B671.4040602@keymile.com>

Dear Gerlando Falauto,

> On 07/05/2012 05:38 PM, Marek Vasut wrote:
> > Dear Gerlando Falauto,
> > 
> >> Some boards might be equipped with different SDRAM configurations.
> >> When that is the case, CPU CS Window Size Register (CS[0]n Size) should
> >> be set to the biggest value through board.cfg file; then its value
> >> can be fixed at runtime according to the detected SDRAM size.
> >> 
> >> Therefore, implement kw_sdram_bs_set(), to be called for instance within
> >> board_early_init_f().
> > 
> > [..]
> > 
> >> +/*
> >> + * kw_sdram_bs_set - writes SDRAM Bank size
> >> + */
> >> +void kw_sdram_bs_set(enum memory_bank bank, u32 size)
> > 
> > The enum is declared somewhere, right ?
> 
> Yes, in arch/arm/include/asm/arch-kirkwood/cpu.h.
> 
> It's the same enum also used by other functions {declared, defined}
> within the same {header, source} file, like:
> 
> u32 kw_sdram_bs(enum memory_bank bank)

Good, add my

Reviewed-by: Marek Vasut <marex@denx.de>

> 
> Best regards,
> Gerlando

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-05 15:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 14:28 [U-Boot] [PATCH 1/2] kirkwood: implement kw_sdram_bs_set() Gerlando Falauto
2012-07-05 14:28 ` [U-Boot] [PATCH 2/2] km_arm: enable SDRAM window size fixup Gerlando Falauto
2012-07-05 15:38 ` [U-Boot] [PATCH 1/2] kirkwood: implement kw_sdram_bs_set() Marek Vasut
2012-07-05 15:44   ` Gerlando Falauto
2012-07-05 15:51     ` Marek Vasut [this message]
2012-07-06 11:50 ` [U-Boot] [PATCH v2 " Gerlando Falauto
2012-07-06 15:41   ` Marek Vasut
2012-07-20  6:15   ` Prafulla Wadaskar
2012-07-20 11:40     ` Marek Vasut
2012-07-20 12:30       ` Holger Brunck
2012-07-06 11:50 ` [U-Boot] [PATCH v2 2/2] km_arm: enable SDRAM window size fixup Gerlando Falauto
2012-07-20  6:30   ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207051751.52434.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox