From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 5 Jul 2012 19:10:48 +0200 Subject: [U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0 In-Reply-To: <20120705161828.GA10143@bill-the-cat> References: <4FE85CB5.6070505@kmckk.co.jp> <20120627174015.GC28055@bill-the-cat> <4FEBAFE2.4000906@kmckk.co.jp> <4FEC4195.1020400@kmckk.co.jp> <4FEC70ED.5090200@ti.com> <4FED7715.2060709@kmckk.co.jp> <20120705135726.3872a2bd@aari01-12> <20120705161828.GA10143@bill-the-cat> Message-ID: <20120705191048.328459cc@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Thu, 5 Jul 2012 09:18:28 -0700, Tom Rini wrote: > On Thu, Jul 05, 2012 at 01:57:26PM +0200, Albert ARIBAUD wrote: > > Hi Tetsuyuki, > > > > On Fri, 29 Jun 2012 18:36:21 +0900, Tetsuyuki Kobayashi > > wrote: > > > save_boot_params_default() in cpu.c accesses uninitialized stack area > > > when it compiled with -O0 (not optimized). > > > > > > Signed-off-by: Tetsuyuki Kobayashi > > > --- > > > Changes for v2: > > > - include and use __naked instead of > > > __attribute__((naked)) > > > > > > Changes for v3: > > > - move __naked after void > > > - reformat comments > > > > > > arch/arm/cpu/armv7/cpu.c | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > Applied to u-boot-arm/master, thanks. > > Oh no... > cpu.c: In function 'save_boot_params_default': > cpu.c:48:1: warning: -fstack-usage not supported for this target [enabled by default] > > Last time we made a const uint32 out of the instruction instead (see > 494931a). I don't think that's appropriate here however. Maybe we can > declare the function weak in assembly instead, then we won't need the > naked part and won't have this warning. Meanwhile I'll remove this patch from my tree. Amicalement, -- Albert.