public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment
Date: Thu, 5 Jul 2012 20:47:06 +0200	[thread overview]
Message-ID: <201207052047.06541.marex@denx.de> (raw)
In-Reply-To: <CAA3CPjVdvobb3SXo1kAu_o-ZB1gEciZYKsx26wS8wNg8dhwsig@mail.gmail.com>

Dear Ilya Yanok,

> Hi Tom,
> 
> On Thu, Jul 5, 2012 at 9:15 PM, Tom Rini <trini@ti.com> wrote:
> > On Wed, Jul 04, 2012 at 05:03:59PM +0400, Ilya Yanok wrote:
> > `
> > 
> > > From: Tom Rini <trini@ti.com>
> > > 
> > > The USB spec says that 32 bytes is the minimum required alignment.
> > > However on some platforms we have a larger minimum requirement for
> > > cache coherency.  In those cases, use that value rather than the USB
> > > spec minimum.  We add a cpp check to <usb.h> to define
> > > USB_DMA_MINALIGN and make use of it in ehci-hcd.c and musb_core.h.  We
> > > cannot use MAX() here as we are not allowed to have tests inside of
> > > align(...).
> > > 
> > > Cc: Marek Vasut <marex@denx.de>
> > > Signed-off-by: Tom Rini <trini@ti.com>
> > > [ilya.yanok]: fix size alignment, drop (incorrect) rounding
> > > when invalidating the buffer. If we got unaligned buffer from the
> > > upper layer -- that's definetely a bug so it's good to buzz
> > > about it. But we have to align the buffer length -- upper layers
> > > should take care to reserve enough space.
> > > Signed-off-by: Ilya Yanok <ilya.yanok@cogentembedded.com>
> > 
> > So trying this on ethernet still gives a handful of unaligned areas.  Do
> 
>  Not surprised. USB Ethernet drivers are unfixed wrt cache alignment.

Well I fixed the ASIX, but now that I think about it, the fix might not be 
enough.

> you have a beagleboard xM available?


> Unfortunately no.

Any ARMv7 chip shall be OK.

> 
> Regards, Ilya.

Best regards,
Marek Vasut

      reply	other threads:[~2012-07-05 18:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 13:03 [U-Boot] [PATCH] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Ilya Yanok
2012-07-04 20:24 ` Marek Vasut
2012-07-05 18:44   ` Ilya Yanok
2012-07-05 19:58     ` Marek Vasut
2012-07-05 20:27       ` Ilya Yanok
2012-07-05 20:55         ` Marek Vasut
2012-07-05 17:15 ` Tom Rini
2012-07-05 18:25   ` Ilya Yanok
2012-07-05 18:47     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207052047.06541.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox