[U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

Mike Frysinger
2012-08-02T17:47:44Z

On Thursday 02 August 2012 03:16:18 Marek Vasut wrote:
> Dear Mike Frysinger,
>
> > On Tuesday 31 July 2012 02:37:01 Lukasz Majewski wrote:
> > > --- /dev/null
> > > +++ b/common/cmd_dfu.c
> > >
> > > + static char *s = "dfu";
> >
> > no need for this to be static
>
> It can be pulled out of the function and be made into const static

err, there's no point. the static markings here are for the pointer "s", not
the stuff it's pointing to "dfu".

use:
char s[] = "dfu";
and it'll probably all optimize away correctly
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120802/e8c413ea/attachment.pgp>