[U-Boot] [PATCH 5/7] dfu:cmd: Support for DFU u-boot command

Mike Frysinger
2012-07-20T14:43:01Z

On Friday 20 July 2012 07:33:49 Marek Vasut wrote:
> Dear Mike Frysinger,
> > On Wednesday 04 July 2012 10:39:20 Marek Vasut wrote:
> > > > Putting there the __func__ name would improve structure and speed up
> > > > finding right place.
> > >
> > > And if you want to use even __LINE__, look up __stringify patch in the
> > > ML archives ;-)
> >
> > ugh, no, let's not use __LINE__ anywhere other than debug(). it has no
> > business in code we ship as it is pointless bloated noise.
>
> Helps find out the problematic place in code ...

except the code changes thus invalidating the line numbers, and how often are
you putting the same string in multiple places that you can't easily
coordinate where it came from ? if people are using the same exact string in
multiple places, that sounds like a different problem.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120720/e9bf6f8a/attachment.pgp>