[U-Boot] [PATCH 4/7] dfu: MMC specific routines for DFU operation

Marek Vasut
2012-07-03T22:31:14Z

Dear Tom Rini,

[...]

> > > > > + debug("%s: %s 0x%p\n", __func__, cmd_buf, cmd_buf);
> > > > > + run_command(cmd_buf, 0);
> > > >
> > > > Holy Moly ... can we not make this into simple calls to those
> > > > subsystems ? Instead invoking command is crazy ;-)
> > >
> > > Are they really simple? There's a few other places we do this, and so
> > > long as it's documented that DFU depends on CONFIG_FAT_WRITE for
> > > writing to fat and so forth.
> >
> > Well ain't it easier to call fat_write() or similar?
>
> Assuming that most of the logic in do_fat_fswrite is needed, no. And I
> think a good portion of it is, at first glance at least.

Abstracting it out into a function won't cut it?

Best regards,
Marek Vasut