[U-Boot] [PATCH v2 3/7] dfu: DFU backend implementation

Wolfgang Denk
2012-07-27T11:58:48Z

Dear Lukasz Majewski,

In message <1341416922-13792-4-git-send-email-l.majewski@samsung.com> you wrote:
> New, separate driver at ./drivers/dfu has been added. It allows platform
> and storage independent operation of DFU.

Sorry for a probably stupid question, but I know basicly zero about
DFU. We are talking about "storage independent" here. Does this
also mean file system independent?

> +static char *dfu_get_dev_type(enum dfu_device_type t)
> +{
> + static char *dev_t[] = {NULL, "MMC", "ONENAND", "NAND" };
> + return dev_t[t];
> +}

So this currently supports MMC, OneNAND and NAND as storage devices?

> +static char *dfu_get_layout(enum dfu_device_type l)
> +{
> + static char *dfu_layout[] = {NULL, "RAW_ADDR", "FAT", "EXT" };
> + return dfu_layout[l];
> +}

And FAT (or VFAT?) and EXT (as in EXT2? or EXT3? or ... ?) as file
systems?

> +enum dfu_device_type {
> + MMC = 1,
> + ONENAND,
> + NAND
> +};
> +
> +enum dfu_layout {
> + RAW_ADDR = 1,
> + FAT,
> + EXT,
> +};

MMC, NAND, FAT and EXT are very generic names that heavily pollute on
the global name space. Please chose more specific names, probaly also
indicating the meaning (EXT could be some "extension" or "external" or
whatever - the name does not indicate that this is a file system type
here.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is your destiny. - Darth Vader