[U-Boot] pull request for u-boot-tegra/master

Simon Glass
2012-03-12T20:24:51Z

+Jerry

Hi Tom,

On Mon, Mar 12, 2012 at 12:30 PM, Tom Warren <TWarren@nvidia.com> wrote:
> Folks,
>
>> -----Original Message-----
>> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>> Sent: Saturday, March 10, 2012 12:35 PM
>> To: Wolfgang Denk
>> Cc: Albert ARIBAUD; Tom Warren; Stephen Warren; U-Boot Mailing List
>> Subject: Re: pull request for u-boot-tegra/master
>>
>> Hi,
>>
>> On Sat, Mar 10, 2012 at 12:25 AM, Wolfgang Denk <wd@denx.de> wrote:
>> > Dear Albert,
>> >
>> > In message
>> <5FBF8E85CA34454794F0F7ECBA79798F37971BC102@HQMAIL04.nvidia.com> Tom Warren
>> wrote:
>> >>
>> >> Please pull u-boot-tegra/master into arm master. Thanks!
>> >
>> >
>> > Please do NOT pull this.
>> >
>> >> ? ? ? ns16550: Add function to drain serial output
>> >> ? ? ? Enable printf() console if pre-console putc() is available
>> >> ? ? ? tegra: Implement pre-console putc() for fdt warning
>> >> ? ? ? tegra: Enable pre-console putc() for Tegra boards
>> >
>> > I'm not OK with these patches yet. ? Also, they affect common code.
>>
>> [speaking for Stephen here, and from my understanding so I may have this a
>> bit wrong]
>>
>> There are separate from the others, added at Stephen's request so that the
>> board will not be a brick if someone flashes the wrong binary onto the
>> board. Stephen's issue is that he wants u-boot.bin to include both the U-
>> Boot binary and the device tree binary. He created a patch for this.
>>
>> http://patchwork.ozlabs.org/patch/145633/
>>
>> In any case regardless of the resolution of that issue we need to get some
>> sort of panic message to the user for SPL and device tree problems.
>>
>> I agree that these four patches need review before pulling. I have responded
>> on the other threads.
>>
>> Regards,
>> Simon
>
> Is there a way we can get this unstuck so a pull request can go through? Maybe put back Stephen's u-boot.bin change in CL#145633, and remove the 4 pre-console patches until a scheme can be cooked up that everyone agrees with? I'm basically dead in the water until I get this baseline set of USB/fdt patches in - the next patches for Tegra2 that have been queued up for weeks all depend on the fdt patches to go in first (I2C, warmboot/LP0, LCD, kbd).

Yes, I'm sorry about this also.

I don't like Stephen's change because it changes the meaning of
u-boot.bin, and I really thought the CONFIG_OF_CONTROL stuff was
pretty good as is. But if Wolfgang or Jerry do like it, then that's
fine, we can change things.

Other than that, we need to wait until the panic stuff is sorted out.
We sort-of have a plan (revert 295d3942, replace with something more
like the pre-console panic, and make it the board's responsibility to
select which UARTs can be used). I will come up with a new series in
the next few days, and we will see where it goes.

If Stephen decides he is happy for the moment with pulling it as it
originally was (without the 4 panic patches and without the u-boot
Makefile change) then I'm fine with that also. We can then untie the
two things. But that means that for now if you flash U-Boot without an
fdt then you get no message and you will have to RTFM
(README.fdt-control) or ask on list.

Regards,
Simon

>
> Thanks,
>
> Tom
>>
>> >
>> > Best regards,
>> >
>> > Wolfgang Denk
>> >
>> > --
>> > DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel
>> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>> > Never underestimate the power of human stupidity ?when ?it ?comes ?to
>> > using technology they don't understand.
> --
> nvpublic
>