public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails
Date: Tue, 10 Jul 2012 03:54:28 +0200	[thread overview]
Message-ID: <201207100354.29068.marex@denx.de> (raw)
In-Reply-To: <1341859963-420-1-git-send-email-timur@freescale.com>

Dear Timur Tabi,

> Now that phy_startup() can return an actual error code, check for that
> error code and abort network initialization if the PHY fails.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>
> Acked-by: Nobuhiro Iwamamatsu <nobuhiro.iwamatsu.yj@renesas.com> (sh_eth
> part) Acked-by: Stephan Linz <linz@li-pro.net> (Xilinx part,
> xilinx_axi_emac and xilinx_ll_temac) Reviewed-by: Marek Vasut
> <marex@denx.de> (FEC part)
> ---
>  drivers/net/fec_mxc.c         |    8 +++++++-
>  drivers/net/fm/eth.c          |    9 ++++++++-
>  drivers/net/sh_eth.c          |    6 +++++-
>  drivers/net/tsec.c            |    8 +++++++-
>  drivers/net/xilinx_axi_emac.c |    6 +++++-
>  drivers/net/xilinx_ll_temac.c |    8 +++++++-
>  6 files changed, 39 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index eee41d7..5700552 100644

A whining remark ... please keep changelog in here ;-)

[...]

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-10  1:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 18:52 [U-Boot] [PATCH 2/2] [v3] net: abort network initialization if the PHY driver fails Timur Tabi
2012-07-10  1:54 ` Marek Vasut [this message]
2012-07-10 15:54 ` Joe Hershberger
2012-07-10 16:15   ` Timur Tabi
2012-07-10 18:30     ` Joe Hershberger
2012-07-10 18:35       ` Timur Tabi
2012-07-10 18:36         ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207100354.29068.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox