* [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning
@ 2012-07-10 5:34 Rajeshwari Shinde
2012-07-10 5:37 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rajeshwari Shinde @ 2012-07-10 5:34 UTC (permalink / raw)
To: u-boot
Fixed the compiler warning message.
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
arch/arm/cpu/armv7/exynos/system.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c
index cc6ee03..4426611 100644
--- a/arch/arm/cpu/armv7/exynos/system.c
+++ b/arch/arm/cpu/armv7/exynos/system.c
@@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
{
struct exynos5_sysreg *sysreg =
(struct exynos5_sysreg *)samsung_get_base_sysreg();
- unsigned int phy_cfg;
/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
--
1.7.4.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning
2012-07-10 5:34 [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning Rajeshwari Shinde
@ 2012-07-10 5:37 ` Marek Vasut
2012-07-10 5:48 ` Jaehoon Chung
2012-07-10 6:50 ` Wolfgang Denk
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2012-07-10 5:37 UTC (permalink / raw)
To: u-boot
Dear Rajeshwari Shinde,
> Fixed the compiler warning message.
Acked-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> arch/arm/cpu/armv7/exynos/system.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/exynos/system.c
> b/arch/arm/cpu/armv7/exynos/system.c index cc6ee03..4426611 100644
> --- a/arch/arm/cpu/armv7/exynos/system.c
> +++ b/arch/arm/cpu/armv7/exynos/system.c
> @@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
> {
> struct exynos5_sysreg *sysreg =
> (struct exynos5_sysreg *)samsung_get_base_sysreg();
> - unsigned int phy_cfg;
>
> /* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
> if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning
2012-07-10 5:34 [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning Rajeshwari Shinde
2012-07-10 5:37 ` Marek Vasut
@ 2012-07-10 5:48 ` Jaehoon Chung
2012-07-10 5:56 ` Rajeshwari Birje
2012-07-10 6:50 ` Wolfgang Denk
2 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2012-07-10 5:48 UTC (permalink / raw)
To: u-boot
Hi Rajeshwari,
How do you think about fixing other warning messages?
If you are inconvenience, i will fix it.
pinmux.c: In function 'exynos_pinmux_config':
pinmux.c:100:20: warning: 'gpio_func' may be used uninitialized in this function [-Wuninitialized]
pinmux.c:69:16: note: 'gpio_func' was declared here
pinmux.c:99:31: warning: 'start' may be used uninitialized in this function [-Wuninitialized]
pinmux.c:69:9: note: 'start' was declared here
Best Regards,
Jaehoon Chung
On 07/10/2012 02:34 PM, Rajeshwari Shinde wrote:
> Fixed the compiler warning message.
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> arch/arm/cpu/armv7/exynos/system.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c
> index cc6ee03..4426611 100644
> --- a/arch/arm/cpu/armv7/exynos/system.c
> +++ b/arch/arm/cpu/armv7/exynos/system.c
> @@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
> {
> struct exynos5_sysreg *sysreg =
> (struct exynos5_sysreg *)samsung_get_base_sysreg();
> - unsigned int phy_cfg;
>
> /* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
> if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning
2012-07-10 5:48 ` Jaehoon Chung
@ 2012-07-10 5:56 ` Rajeshwari Birje
0 siblings, 0 replies; 5+ messages in thread
From: Rajeshwari Birje @ 2012-07-10 5:56 UTC (permalink / raw)
To: u-boot
Hi Jaehoon Chung,
I just fixed the waning messages i saw on u-boot-usb.
Did not find these warning messages in that tree.
Will fix these. Sorry for inconvenience.
Regards,
Rajeshwari Shinde.
On Tue, Jul 10, 2012 at 11:18 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Rajeshwari,
>
> How do you think about fixing other warning messages?
> If you are inconvenience, i will fix it.
>
> pinmux.c: In function 'exynos_pinmux_config':
> pinmux.c:100:20: warning: 'gpio_func' may be used uninitialized in this function [-Wuninitialized]
> pinmux.c:69:16: note: 'gpio_func' was declared here
> pinmux.c:99:31: warning: 'start' may be used uninitialized in this function [-Wuninitialized]
> pinmux.c:69:9: note: 'start' was declared here
>
> Best Regards,
> Jaehoon Chung
>
> On 07/10/2012 02:34 PM, Rajeshwari Shinde wrote:
>
>> Fixed the compiler warning message.
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>> arch/arm/cpu/armv7/exynos/system.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c
>> index cc6ee03..4426611 100644
>> --- a/arch/arm/cpu/armv7/exynos/system.c
>> +++ b/arch/arm/cpu/armv7/exynos/system.c
>> @@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
>> {
>> struct exynos5_sysreg *sysreg =
>> (struct exynos5_sysreg *)samsung_get_base_sysreg();
>> - unsigned int phy_cfg;
>>
>> /* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
>> if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning
2012-07-10 5:34 [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning Rajeshwari Shinde
2012-07-10 5:37 ` Marek Vasut
2012-07-10 5:48 ` Jaehoon Chung
@ 2012-07-10 6:50 ` Wolfgang Denk
2 siblings, 0 replies; 5+ messages in thread
From: Wolfgang Denk @ 2012-07-10 6:50 UTC (permalink / raw)
To: u-boot
Dear Rajeshwari Shinde,
In message <1341898474-14729-1-git-send-email-rajeshwari.s@samsung.com> you wrote:
> Fixed the compiler warning message.
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> arch/arm/cpu/armv7/exynos/system.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An expert is a person who avoids the small errors while sweeping on
to the grand fallacy.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-10 6:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-10 5:34 [U-Boot] [PATCH] EXYNOS: Fix USB compiler warning Rajeshwari Shinde
2012-07-10 5:37 ` Marek Vasut
2012-07-10 5:48 ` Jaehoon Chung
2012-07-10 5:56 ` Rajeshwari Birje
2012-07-10 6:50 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox