From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sughosh Ganu <urwithsughosh@gmail.com>
Date: Wed, 11 Jul 2012 17:38:37 +0530
Subject: [U-Boot] [PATCH V3 2/3] arm/davinci: spl - boot device selection
In-Reply-To: <4FFD66D7.4080401@ti.com>
References: <1341860020-11507-1-git-send-email-mikhail.kshevetskiy@gmail.com>
	<1341860020-11507-2-git-send-email-mikhail.kshevetskiy@gmail.com>
	<20120710183906.GA24958@Hardy>
	<20120710232053.7bfb3858@weasel.local>
	<20120711063824.GA26793@Hardy> <4FFD371C.5000704@ti.com>
	<20120711104036.GB27810@Hardy> <4FFD5996.3050103@ti.com>
	<20120711110504.GA27883@Hardy> <4FFD66D7.4080401@ti.com>
Message-ID: <20120711120837.GA28077@Hardy>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed Jul 11, 2012 at 04:43:19AM -0700, Tom Rini wrote:
> On 07/11/2012 04:05 AM, Sughosh Ganu wrote:

<snip>

> >> I'm fine saying that we should wrap the call around an #if, but I
> >> would expect it to be set in the common case and only not set in
> >> custom production boards.
> > 
> > Correct, so all that is needed for SD/MMC loading can still be kept
> > separate from, say nand load in the spl.c file, isn't it. So if sd/mmc
> > spl load needs heap to be set up, can't it be done only for that
> > case.
> 
> Yes, but we don't want to have N locations that set up the heap.  We
> want one location that will, if the board has defined a heap area, we
> set it up.  Or to put it another way, calling mem_malloc_init isn't part
> of the mmc boot-flow, it's part of the general boot flow.

Fair enough. My only concern was just that if some feature is not
needed for a board, it should be possible to exclude it out.

-sughosh