[U-Boot] [PATCH] beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3

[U-Boot] [PATCH] beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3

[Peter Meerwald]

From: Peter Meerwald <p.meerwald@bct-electronic.com>

Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
---
 board/ti/beagle/beagle.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
index a02a350..f13f1be 100644
--- a/board/ti/beagle/beagle.c
+++ b/board/ti/beagle/beagle.c
@@ -245,6 +245,7 @@ unsigned int get_expansion_id(void)
 	return expansion_config.device_vendor;
 }
 
+#ifdef CONFIG_VIDEO_OMAP3
 /*
  * Configure DSS to display background color on DVID
  * Configure VENC to display color bar on S-Video
@@ -299,6 +300,7 @@ static void beagle_dvi_pup(void)
 		break;
 	}
 }
+#endif
 
 /*
  * Routine: misc_init_r
@@ -483,9 +485,11 @@ int misc_init_r(void)
 
 	dieid_num_r();
 
+#ifdef CONFIG_VIDEO_OMAP3
 	beagle_dvi_pup();
 	beagle_display_init();
 	omap3_dss_enable();
+#endif
 
 	return 0;
 }
-- 
1.7.5.4

[U-Boot] [PATCH] beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3

[Tom Rini]

On Tue, Jul 10, 2012 at 06:07:34PM +0200, Peter Meerwald wrote:

> From: Peter Meerwald <p.meerwald@bct-electronic.com>
> 
> Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>

So, why?  Are you doing custom builds for beagleboard, but with the dss
stuff removed?  To try and make beagle an easier starting point for
custom hardware?  Thanks!

-- 
Tom

[U-Boot] [PATCH] beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3

[Peter Meerwald]

> So, why?  Are you doing custom builds for beagleboard, but with the dss
> stuff removed?  To try and make beagle an easier starting point for
> custom hardware?  Thanks!

I consider a CONFIG #define which only works when defined a bug

thx, p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)

[U-Boot] [PATCH] beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3

[Albert ARIBAUD]

Hi Peter,

On Tue, 10 Jul 2012 20:21:28 +0200 (CEST), Peter Meerwald <pmeerw@pmeerw.net> wrote:
> 
> > So, why?  Are you doing custom builds for beagleboard, but with the dss
> > stuff removed?  To try and make beagle an easier starting point for
> > custom hardware?  Thanks!
> 
> I consider a CONFIG #define which only works when defined a bug

Trying to understand here. So the problem you are addressing is that even when
CONFIG_VIDEO_OMAP3 is not defined, some video code still gets compiled?

> thx, p.
> 

Amicalement,
-- 
Albert.

[U-Boot] [PATCH] beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3

[Tom Rini]

On 07/12/2012 11:27 AM, Albert ARIBAUD wrote:
> Hi Peter,
> 
> On Tue, 10 Jul 2012 20:21:28 +0200 (CEST), Peter Meerwald <pmeerw@pmeerw.net> wrote:
>>
>>> So, why?  Are you doing custom builds for beagleboard, but with the dss
>>> stuff removed?  To try and make beagle an easier starting point for
>>> custom hardware?  Thanks!
>>
>> I consider a CONFIG #define which only works when defined a bug
> 
> Trying to understand here. So the problem you are addressing is that even when
> CONFIG_VIDEO_OMAP3 is not defined, some video code still gets compiled?

Right.  I've taken this into my next branch (I hadn't announced yet
since I can't go run boot tests right now) since it's a logical fix.

-- 
Tom