public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Date: Fri, 13 Jul 2012 23:26:00 +0200	[thread overview]
Message-ID: <20120713212600.B16BA2000F2@gemini.denx.de> (raw)
In-Reply-To: <5000106B.5090007@freescale.com>

Dear Tabi Timur-B04825,

In message <5000106B.5090007@freescale.com> you wrote:
>
> > It will work by chance, accessing random data.  This is crap.
> 
> It is not crap, and it will not work by chance.  It is not accessing 
> random data, it is accessing the CRC in the old location, just like the 
> current code does today.

If you have the CRC at 0xFC, and the CRC is incorrect, then it _will_
access random data, and result inundefined behaviour. Yes, this _is_ a
crappy design.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."                      -- Baron Rothschild, ca. 1800

  reply	other threads:[~2012-07-13 21:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 21:46 [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location Timur Tabi
2012-07-12 22:03 ` sun york-R58495
2012-07-12 22:37   ` Scott Wood
2012-07-12 22:44     ` Timur Tabi
2012-07-12 22:46     ` sun york-R58495
2012-07-12 22:49       ` Scott Wood
2012-07-12 22:52         ` Timur Tabi
2012-07-13  4:32           ` Wolfgang Denk
2012-07-13 12:11             ` Tabi Timur-B04825
2012-07-13 21:26               ` Wolfgang Denk [this message]
2012-07-13  4:30   ` Wolfgang Denk
2012-07-13  4:38     ` sun york-R58495
2012-07-13 12:12       ` Tabi Timur-B04825
2012-07-13 21:22         ` York Sun
2012-07-13 12:10     ` Tabi Timur-B04825
2012-07-13 21:25       ` Wolfgang Denk
2012-07-13 21:29         ` Timur Tabi
2012-07-13 21:32           ` Wolfgang Denk
2012-07-13 21:39             ` Timur Tabi
2012-07-13 21:45         ` Scott Wood
2012-07-13 21:53           ` Timur Tabi
2012-07-13 22:19             ` Scott Wood
2012-07-13 22:22               ` Timur Tabi
2012-07-13 22:41                 ` Scott Wood
2012-07-13 22:46                   ` Timur Tabi
2012-07-13 22:54                     ` Scott Wood
2012-07-13 23:01             ` Wolfgang Denk
2012-07-13 23:12               ` Scott Wood
     [not found]                 ` <C5EFF1F960B6FC4C873CF9BD5FE250210791DCC8@039-SN2MPN1-013.039d.mgd.msft.net>
2012-07-15 12:52                   ` Tabi Timur-B04825
2012-07-16 19:57                 ` Wolfgang Denk
2012-07-16 22:32                   ` Scott Wood
2012-07-13 22:59           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120713212600.B16BA2000F2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox