From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Fri, 13 Jul 2012 23:26:00 +0200 Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location In-Reply-To: <5000106B.5090007@freescale.com> References: <1342129594-7861-1-git-send-email-timur@freescale.com> <9F5356FB-8CA2-44DE-9089-64ABD82CA733@freescale.com> <4FFF51A9.5060500@freescale.com> <1A7ED0F3-8897-4D3B-B7C6-0C71C3F38415@freescale.com> <4FFF5479.8060208@freescale.com> <4FFF5524.2080704@freescale.com> <20120713043258.B1A572000B1@gemini.denx.de> <5000106B.5090007@freescale.com> Message-ID: <20120713212600.B16BA2000F2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tabi Timur-B04825, In message <5000106B.5090007@freescale.com> you wrote: > > > It will work by chance, accessing random data. This is crap. > > It is not crap, and it will not work by chance. It is not accessing > random data, it is accessing the CRC in the old location, just like the > current code does today. If you have the CRC at 0xFC, and the CRC is incorrect, then it _will_ access random data, and result inundefined behaviour. Yes, this _is_ a crappy design. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There are three principal ways to lose money: wine, women, and en- gineers. While the first two are more pleasant, the third is by far the more certain." -- Baron Rothschild, ca. 1800