[U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

Marek Vasut
2012-07-10T18:02:57Z

Dear Stefan Herbrechtsmeier,

> The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage:
> Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in
> usb_storage as it wrongly assumes that every transfer can use
> 4096 bytes per qt_buffer. This is wrong if the start address of
> the data is not page aligned to 4096 bytes and leads to 'EHCI
> timed out on TD' messages because of 'out of buffer pointers'
> in ehci_td_buffer function.
>
> The bug appears during load of a fragmented file and
> read from or write to an unaligned memory address.
>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>

This one is good :-)

Thank you, Stefan! For your contribution and your patience.

I'll test it on friday and I'll talk to WD to include it in current release. The
fix looks very reasonable. Though I'd like to get some tests done. Tom, Ilya,
can you possibly try this on your toys please?
[...]

Best regards,
Marek Vasut