[U-Boot] [PATCH v2 0/4] Add support new arch: c6x

Wolfgang Denk
2012-06-24T13:50:11Z

Dear bond at inmys.ru,

In message <31ab63da18246416f011fefc86653461.squirrel@78.108.93.81> you wrote:
>
> After rework, code in arch/c6x
> tools/checkpatch.pl 0001-Add-support-new-arch-c6x.patch tell me:
> "total: 0 errors, 39 warnings, 3065 lines checked"

Thanks.

> can i try send patch to list, or if not, what i must do with typedefs of
> global_data, volatile in asm/io.h and __kernel... types in
> asm/posix_types.h (all other arch has same code)?

If you really need to come up with your own versions of asm/io.h,
asm/posix_types.h etc. the typedefs are probably OK.

> WARNING: Use of volatile is usually wrong: see
> Documentation/volatile-considered-harmful.txt
> #394: FILE: arch/c6x/include/asm/io.h:14:
> +#define readb(addr) (*(volatile unsigned char *) (addr))

This is indeed unacceptable code, as it does not contain any kind of
memory barrier instructions. Please use proper I/O accessors, resp.
define such.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life would be so much easier if we could just look at the source
code. -- Dave Olson