From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib
Date: Thu, 19 Jul 2012 00:37:57 -0400 [thread overview]
Message-ID: <201207190037.59281.vapier@gentoo.org> (raw)
In-Reply-To: <201207151012.45797.marex@denx.de>
On Sunday 15 July 2012 04:12:45 Marek Vasut wrote:
> Dear Macpaul Lin,
> > +void flush_cache(unsigned long addr, unsigned long size)
> > +{
> > + flush_dcache_range(addr, addr + size);
> > + invalidate_icache_range(addr, addr + size);
>
> You probably want to flush dcache in here and that's it.
i don't think so ... i think that's what flush_dcache_range() is for. and our
common/cmd_*.c files assume that flush_cache() will invalidate icache (see the
bootm/load funcs that write executable content into memory and then flush the
regions).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120719/9274ae24/attachment.pgp>
next prev parent reply other threads:[~2012-07-19 4:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 4:02 [U-Boot] [PATCH] nds32: split common cache access from cpu into lib Macpaul Lin
2012-07-15 8:12 ` Marek Vasut
2012-07-16 2:23 ` Macpaul Lin
2012-07-17 13:44 ` [U-Boot] [PATCH v2] " Macpaul Lin
2012-07-20 16:03 ` Macpaul Lin
2012-07-19 4:37 ` Mike Frysinger [this message]
2012-07-19 4:51 ` [U-Boot] [PATCH] " Macpaul Lin
2012-07-19 9:02 ` Marek Vasut
2012-07-19 13:48 ` Mike Frysinger
2012-07-19 14:02 ` Marek Vasut
2012-07-20 8:24 ` Macpaul Lin
2012-07-20 14:41 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207190037.59281.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox