From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 19 Jul 2012 09:28:26 -0400 Subject: [U-Boot] [PATCH] Added watchdog support for davinchi_dm365evm In-Reply-To: <4FCA31FE.70408@essensium.com> References: <1337532640-1310-1-git-send-email-stijn.souffriau@essensium.com> <201205201459.28436.vapier@gentoo.org> <4FCA31FE.70408@essensium.com> Message-ID: <201207190928.28796.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 02 June 2012 11:32:14 Stijn Souffriau wrote: > On 05/20/2012 08:59 PM, Mike Frysinger wrote: > > On Sunday 20 May 2012 12:50:40 Stijn Souffriau wrote: > >> --- a/board/davinci/dm365evm/dm365evm.c > >> +++ b/board/davinci/dm365evm/dm365evm.c > >> > >> +#ifdef CONFIG_HW_WATCHDOG > >> +static struct davinci_timer * const wdttimer = > >> + (struct davinci_timer *)CONFIG_SYS_WDTTIMERBASE; > >> + > >> +/* WDTCR bit definitions */ > >> +#define WDEN (1<< 14) > >> +#define WDFLAG (1<< 15) > >> +#define WDKEY_SEQ0 (0xa5c6<< 16) > >> +#define WDKEY_SEQ1 (0xda7e<< 16) > > > > if this is an on-chip hardware block, this stuff should be in an > > SoC-specific header > > Yes but as far as I know It only works for the davinci dm356evm. if it's part of the SoC, then i don't see how it could only work for one board. SoC bits belong in the SoC tree (arch/arm//...) while board bits belong in the board tree (board/...). -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: