From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 19 Jul 2012 11:02:21 +0200
Subject: [U-Boot] [PATCH] nds32: split common cache access from cpu into
	lib
In-Reply-To: <201207190037.59281.vapier@gentoo.org>
References: <1342324924-3282-1-git-send-email-macpaul@gmail.com>
	<201207151012.45797.marex@denx.de>
	<201207190037.59281.vapier@gentoo.org>
Message-ID: <201207191102.21389.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Mike Frysinger,

> On Sunday 15 July 2012 04:12:45 Marek Vasut wrote:
> > Dear Macpaul Lin,
> > 
> > > +void flush_cache(unsigned long addr, unsigned long size)
> > > +{
> > > +	flush_dcache_range(addr, addr + size);
> > > +	invalidate_icache_range(addr, addr + size);
> > 
> > You probably want to flush dcache in here and that's it.
> 
> i don't think so ... i think that's what flush_dcache_range() is for.  and
> our common/cmd_*.c files assume that flush_cache() will invalidate icache
> (see the bootm/load funcs that write executable content into memory and
> then flush the regions).

Than it's borked on arm926ejs too ... ?

Best regards,
Marek Vasut