public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] FAT: Make it possible to read from any file position
Date: Thu, 19 Jul 2012 18:44:52 -0400	[thread overview]
Message-ID: <201207191844.53559.vapier@gentoo.org> (raw)
In-Reply-To: <895920526.294134.1342735386480.JavaMail.root@advansee.com>

On Thursday 19 July 2012 18:03:06 Beno?t Th?baudeau wrote:
> --- u-boot-66714b1.orig/fs/fat/fat.c
> +++ u-boot-66714b1/fs/fat/fat.c
> 
> +__u8 get_contents_vfatname_block[MAX_CLUSTSIZE]
> +	__aligned(ARCH_DMA_MINALIGN);

is there any reason for this to be exported ?  could you mark it static ?

>  static long
> -get_contents (fsdata *mydata, dir_entry *dentptr, __u8 *buffer,
> -	      unsigned long maxsize)
> +get_contents (fsdata *mydata, dir_entry *dentptr, unsigned long pos,

delete the space before the "("

>  long
> -do_fat_read (const char *filename, void *buffer, unsigned long maxsize,
> -	     int dols)
> +do_fat_read_at (const char *filename, unsigned long pos, void *buffer,

delete the space before the "("

> +long
> +do_fat_read (const char *filename, void *buffer, unsigned long maxsize,

no spaces before that "("
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120719/ced33472/attachment.pgp>

  reply	other threads:[~2012-07-19 22:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 22:03 [U-Boot] [PATCH 7/7] FAT: Make it possible to read from any file position Benoît Thébaudeau
2012-07-19 22:44 ` Mike Frysinger [this message]
2012-07-19 23:17   ` Benoît Thébaudeau
2012-07-20  3:02     ` Mike Frysinger
2012-07-20 13:22       ` [U-Boot] [PATCH v2 8/8] " Benoît Thébaudeau
2012-09-02 15:28         ` Wolfgang Denk
2012-09-03 14:17           ` Benoît Thébaudeau
2012-09-14 20:49             ` Tom Rini
2012-09-14 22:03               ` Benoît Thébaudeau
2012-09-14 22:02                 ` Tom Rini
2012-09-22 20:32                   ` Benoît Thébaudeau
2012-09-18 18:14         ` [U-Boot] [PATCH v3] " Benoît Thébaudeau
2012-09-27 16:20           ` [U-Boot] [U-Boot, " Tom Rini
2012-09-28 11:32             ` Benoît Thébaudeau
2012-09-28 15:34               ` Stephen Warren
2012-09-28 16:17                 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207191844.53559.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox