From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Fri, 20 Jul 2012 10:28:29 +0200 Subject: [U-Boot] [PATCH v2] video: support exynos fimd driver for various exynos series In-Reply-To: <50076344.40205@samsung.com> References: <4FF24340.7000509@samsung.com> <50076344.40205@samsung.com> Message-ID: <20120720102829.47b82d25@wker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On Thu, 19 Jul 2012 10:30:44 +0900 Donghwa Lee wrote: > This patch support exynos fimd driver for various exynos series different from > existing it supports only exynos4 chip. > > Signed-off-by: Donghwa Lee > Signed-off-by: Kyungmin Park > --- > Changes for v1: > - moves exynos_fimd_get_base_offset() to exynos_fb.h Why? This function is used in exynos_fimd.c file only. Moving it to the header file will result in a warning when compiling files including exynos_fb.h. This function should be in exynos_fimd.c. Thanks, Anatolij