[U-Boot] [PATCH] nds32: split common cache access from cpu into lib

Macpaul Lin
2012-07-19T04:51:55Z

Hi Mike

2012/7/19 Mike Frysinger <vapier@gentoo.org>

> On Sunday 15 July 2012 04:12:45 Marek Vasut wrote:
> > Dear Macpaul Lin,
> > > +void flush_cache(unsigned long addr, unsigned long size)
> > > +{
> > > + flush_dcache_range(addr, addr + size);
> > > + invalidate_icache_range(addr, addr + size);
> >
> > You probably want to flush dcache in here and that's it.
>
> i don't think so ... i think that's what flush_dcache_range() is for. and
> our
> common/cmd_*.c files assume that flush_cache() will invalidate icache (see
> the
> bootm/load funcs that write executable content into memory and then flush
> the
> regions).
> -mike
>

Thanks for clarification.
The patch v2 I've submitted 2 days ago didn't add a dcache flush here. :-)

--
Best regards,
Macpaul Lin