public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ext2fs: fix warning: 'blocknxt' may be used uninitialized
Date: Mon, 23 Jul 2012 11:56:00 -0700	[thread overview]
Message-ID: <20120723185600.GA8985@bill-the-cat> (raw)
In-Reply-To: <20120708205516.791CC20012A@gemini.denx.de>

On Sun, Jul 08, 2012 at 10:55:16PM +0200, Wolfgang Denk wrote:
> Dear Kim Phillips,
> 
> In message <20120703174156.a1082309c2b205216606a004@freescale.com> you wrote:
> > This warning was introduced in 436da3c "ext2load: increase read
> > speed":
> > 
> > ext2fs.c: In function 'ext2fs_read_file':
> > ext2fs.c:458:19: warning: 'blocknxt' may be used uninitialized in this func=
> > tion [-Wuninitialized]
> > 
> > this change makes it go away.
> > 
> > Cc: Eric Nelson <eric.nelson@boundarydevices.com>
> > Cc: Thierry Reding <thierry.reding@avionic-design.de>
> > Cc: Jason Cooper <u-boot@lakedaemon.net>
> > Cc: Andreas Bie=DFmann <andreas.devel@googlemail.com>
> > Cc: Reinhard Arlt <reinhard.arlt@esd-electronics.com>
> > Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> > ---
> > v2: changed to Thierry's recommendation in:
> > 
> > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/134043
> > 
> > build-tested only - please ack
> > 
> >  fs/ext2/ext2fs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks.

This doesn't fix the warning for ELDK 4.2 toolchains (gcc 4.2.2):
ext2fs.c: In function 'ext2fs_read_file':
ext2fs.c:443: warning: 'blocknxt' may be used uninitialized in this
function

-- 
Tom

  reply	other threads:[~2012-07-23 18:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 14:37 [U-Boot] [PATCH] ext2load: increase read speed Jason Cooper
2012-04-26  1:17 ` Eric Nelson
2012-05-08 15:43   ` Jason Cooper
2012-05-08 15:53     ` Eric Nelson
2012-04-26 12:54 ` Thierry Reding
2012-05-08 15:48   ` Jason Cooper
2012-05-08 16:13 ` [U-Boot] [GIT PULL] ext2load speedup Jason Cooper
2012-05-21  1:35   ` [U-Boot] [GIT PULL RESEND] " Jason Cooper
2012-05-21  5:19     ` Wolfgang Denk
2012-06-01 15:41     ` Jason Cooper
2012-06-01 15:54 ` [U-Boot] [PATCH v2] ext2load: increase read speed Jason Cooper
2012-06-21 20:49   ` Wolfgang Denk
2012-07-03 16:05     ` [U-Boot] [PATCH] ext2fs: fix warning: 'blocknxt' may be used uninitialized Kim Phillips
2012-07-03 22:12       ` Andreas Bießmann
2012-07-03 22:41         ` [U-Boot] [PATCH v2] " Kim Phillips
2012-07-04  6:09           ` Thierry Reding
2012-07-06 13:31           ` Jason Cooper
2012-07-08 20:55           ` Wolfgang Denk
2012-07-23 18:56             ` Tom Rini [this message]
2012-07-24  4:59               ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120723185600.GA8985@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox