From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Walle <michael@walle.cc>
Date: Mon, 23 Jul 2012 22:41:22 +0200
Subject: [U-Boot] Invalid Netconsole source MAC address [was: Re:
	[STATUS] v2012.07-rc1 is out - release date July 23]
In-Reply-To: <CANr=Z=aKmR+0bb0D2PPZLwYjSYft6J7simFL5puAjDQWVczPkA@mail.gmail.com>
References: <201207212004.42506.michael@walle.cc>
	<CANr=Z=aKmR+0bb0D2PPZLwYjSYft6J7simFL5puAjDQWVczPkA@mail.gmail.com>
Message-ID: <201207232241.22673.michael@walle.cc>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


Hi Joe,

Am Montag 23 Juli 2012, 21:30:28 schrieb Joe Hershberger:
> On Sat, Jul 21, 2012 at 1:04 PM, Michael Walle <michael@walle.cc> wrote:
> > Mh i guess NetLoop isn't called and thus NetOurEther is never
> > initialized. Similar issue like
> > d7310c7e63ca9ffd42527dc9735cb505cbe908b7. Initializing NetOurEther in
> > net_init() fixes the problem.
> 
> I tested this on Panda board and wireshark reports the correct source
> MAC address.
> 
> Please provide details of which board and driver you are using.

Board: LS-CHLv2/kirkwood arm; ethaddr set to some valid ethernet address ;)

If NetLoop isn't called the internal ethernet address is not initialized. 
Hopefully the following sequence triggers the bug:
 - boot the board, _dont_ do any network interaction
 - setenv stdout nc
 - type sth on the serial console

--> now the packets are send with source MAC == 00:00:00:00:00:00.

If you look at the code NetOurEther is only initialized in NetLoop and i guess 
NetLoop() isn't called for outgoing NetConsole packets.

-- 
Michael