From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 27 Jul 2012 16:31:36 +0200 Subject: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed In-Reply-To: <454938890.703921.1343398424978.JavaMail.root@advansee.com> References: <454938890.703921.1343398424978.JavaMail.root@advansee.com> Message-ID: <201207271631.36893.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Beno?t Th?baudeau, > Dear Marek, > > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > > Do you think > > > using PAGE_SIZE from would be fine since these > > > 4096 are > > > nothing more than page sizes? > > > > Isn't that intel-specific? > > I don't know. The code does not say so. What is sure is that page sizes > should be arch-specific, even with several possible page sizes per arch. > But this #define seems to fit our needs, so why not use it? The only thing > that would make me reluctant to using it is that this code might change > without further notice. That's exactly my point. And it'll break anything with pages smaller than 4k. Please define it in ehci.h [..] Best regards, Marek Vasut