From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx
Date: Sat, 28 Jul 2012 00:14:36 +0200 [thread overview]
Message-ID: <20120727221436.97087200166@gemini.denx.de> (raw)
In-Reply-To: <201207272326.26896.marex@denx.de>
Dear Marek,
In message <201207272326.26896.marex@denx.de> you wrote:
>
> > > - k = (immr << 16) | *((ushort *) & immap->im_cpm.cp_dparam[0xB0]);
> > > + k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]);
> >
> > I think this is wrong. readw() is a little endian I/O accessor, but
> > PPC is all big-endian.
>
> So in_be32 it is, I guess?
Wrong again. Looks more like in_be16 to me...
> > Guess this was untested?
>
> Of course it was not. Had trouble even sending this via the crappy cellular>
> connection on a train ;-)
You tested it? And it worked? I'm surprised. ... Really??
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Worlds are conquered, galaxies destroyed -- but a woman is always a
woman.
-- Kirk, "Conscience of the King", stardate unknown
next prev parent reply other threads:[~2012-07-27 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 20:00 [U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx Marek Vasut
2012-07-27 20:56 ` Wolfgang Denk
2012-07-27 21:26 ` Marek Vasut
2012-07-27 22:14 ` Wolfgang Denk [this message]
2012-07-27 22:29 ` Marek Vasut
2012-07-27 22:57 ` [U-Boot] [PATCH V2] " Marek Vasut
2012-07-30 7:45 ` Wolfgang Denk
2012-07-30 8:02 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120727221436.97087200166@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox