From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 27 Jul 2012 23:26:26 +0200
Subject: [U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx
In-Reply-To: <20120727205644.5DCDC203AC0@gemini.denx.de>
References: <1343419212-18716-1-git-send-email-marex@denx.de>
	<20120727205644.5DCDC203AC0@gemini.denx.de>
Message-ID: <201207272326.26896.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1343419212-18716-1-git-send-email-marex@denx.de> you wrote:
> > cpu.c: In function ?check_CPU?:
> > cpu.c:256:2: warning: dereferencing type-punned pointer will break
> > strict-aliasing rules [-Wstrict-aliasing]
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> > 
> >  arch/powerpc/cpu/mpc8xx/cpu.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> ...
> 
> > -	k = (immr << 16) | *((ushort *) & immap->im_cpm.cp_dparam[0xB0]);
> > +	k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]);
> 
> I think this is wrong.  readw() is a little endian I/O accessor, but
> PPC is all big-endian.

So in_be32 it is, I guess?

> Guess this was untested?

Of course it was not. Had trouble even sending this via the crappy cellular 
connection on a train ;-)

Thanks for catching it, glad you reviewed this.

> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut