From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 28 Jul 2012 00:29:32 +0200
Subject: [U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx
In-Reply-To: <20120727221436.97087200166@gemini.denx.de>
References: <1343419212-18716-1-git-send-email-marex@denx.de>
	<201207272326.26896.marex@denx.de>
	<20120727221436.97087200166@gemini.denx.de>
Message-ID: <201207280029.32448.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Marek,
> 
> In message <201207272326.26896.marex@denx.de> you wrote:
> > > > -	k = (immr << 16) | *((ushort *) & immap-
>im_cpm.cp_dparam[0xB0]);
> > > > +	k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]);
> > > 
> > > I think this is wrong.  readw() is a little endian I/O accessor, but
> > > PPC is all big-endian.
> > 
> > So in_be32 it is, I guess?
> 
> Wrong again. Looks more like in_be16 to me...

Ok, lemme try V2.

> > > Guess this was untested?
> > 
> > Of course it was not. Had trouble even sending this via the crappy
> > cellular> connection on a train ;-)
> 
> You tested it? And it worked?  I'm surprised. ...  Really??

No, I did not test it. The train control unit is MPC5200 too ... so I really had 
no hardware to test it on in close proximity ;-)

> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut