public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function
Date: Sat, 28 Jul 2012 21:39:05 +0200	[thread overview]
Message-ID: <201207282139.05998.marex@denx.de> (raw)
In-Reply-To: <20120728193654.6341B200346@gemini.denx.de>

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1343483279-11572-1-git-send-email-marex@denx.de> you wrote:
> > This function converts static number to string in preprocessor.
> > This is useful as it allows higher usage of puts() in favour of printf()
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Mike Frysinger <vapier@gentoo.org>
> > ---
> > 
> >  include/common.h |    7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> We have similar things already, and we don't add dead code - you add a
> macro without users here.

It's used in 2/2 ... what macro do you have in mind ?

> If you want to unify the use of such a macro, fine - but then please
> replace all ocurrences of equivalent definitions all over the code.
> 
> Thanks.
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-28 19:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-28 13:47 [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function Marek Vasut
2012-07-28 13:47 ` [U-Boot] [RFC] [PATCH 2/2] crazy: Sort u_boot_cmd at runtime Marek Vasut
2012-07-28 17:46   ` Wolfgang Denk
2012-07-28 18:39     ` Marek Vasut
2012-07-28 19:53       ` Wolfgang Denk
2012-07-28 20:54         ` Marek Vasut
2012-07-28 19:36 ` [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function Wolfgang Denk
2012-07-28 19:39   ` Marek Vasut [this message]
2012-07-28 19:57     ` Wolfgang Denk
2012-07-28 20:59       ` Marek Vasut
2012-07-31  8:01       ` Mike Frysinger
2012-07-31 13:55         ` Marek Vasut
2012-07-31 14:06           ` Mike Frysinger
2012-07-31 14:08             ` Marek Vasut
2012-07-31 14:16               ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207282139.05998.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox