From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 28 Jul 2012 21:39:05 +0200
Subject: [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function
In-Reply-To: <20120728193654.6341B200346@gemini.denx.de>
References: <1343483279-11572-1-git-send-email-marex@denx.de>
	<20120728193654.6341B200346@gemini.denx.de>
Message-ID: <201207282139.05998.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1343483279-11572-1-git-send-email-marex@denx.de> you wrote:
> > This function converts static number to string in preprocessor.
> > This is useful as it allows higher usage of puts() in favour of printf()
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Mike Frysinger <vapier@gentoo.org>
> > ---
> > 
> >  include/common.h |    7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> We have similar things already, and we don't add dead code - you add a
> macro without users here.

It's used in 2/2 ... what macro do you have in mind ?

> If you want to unify the use of such a macro, fine - but then please
> replace all ocurrences of equivalent definitions all over the code.
> 
> Thanks.
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut