public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix
Date: Sun, 29 Jul 2012 03:33:02 +0200	[thread overview]
Message-ID: <201207290333.02699.marex@denx.de> (raw)
In-Reply-To: <1343515844-5764-3-git-send-email-otavio@ossystems.com.br>

Dear Otavio Salvador,

> As the register accessing mode is the same for all i.MXS SoCs we ought
> to use 'mxs' prefix intead of 'mx28'.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  arch/arm/cpu/arm926ejs/mxs/clock.c           |    4 +-
>  arch/arm/cpu/arm926ejs/mxs/iomux.c           |    6 +-
>  arch/arm/cpu/arm926ejs/mxs/mx28.c            |    6 +-
>  arch/arm/include/asm/arch-mxs/regs-apbh.h    |  254
> +++++++++++++------------- arch/arm/include/asm/arch-mxs/regs-bch.h     | 
>  42 ++---
>  arch/arm/include/asm/arch-mxs/regs-clkctrl.h |   58 +++---
>  arch/arm/include/asm/arch-mxs/regs-common.h  |   34 ++--
>  arch/arm/include/asm/arch-mxs/regs-digctl.h  |   50 ++---
>  arch/arm/include/asm/arch-mxs/regs-gpmi.h    |   26 +--
>  arch/arm/include/asm/arch-mxs/regs-i2c.h     |   28 +--
>  arch/arm/include/asm/arch-mxs/regs-lcdif.h   |   64 +++----
>  arch/arm/include/asm/arch-mxs/regs-lradc.h   |   48 ++---
>  arch/arm/include/asm/arch-mxs/regs-ocotp.h   |   86 ++++-----
>  arch/arm/include/asm/arch-mxs/regs-pinctrl.h |  168 ++++++++---------
>  arch/arm/include/asm/arch-mxs/regs-power.h   |   28 +--
>  arch/arm/include/asm/arch-mxs/regs-rtc.h     |   28 +--
>  arch/arm/include/asm/arch-mxs/regs-ssp.h     |   40 ++--
>  arch/arm/include/asm/arch-mxs/regs-timrot.h  |   38 ++--
>  arch/arm/include/asm/arch-mxs/regs-usbphy.h  |   20 +-
>  arch/arm/include/asm/arch-mxs/sys_proto.h    |    6 +-
>  drivers/gpio/mxs_gpio.c                      |   16 +-
>  drivers/usb/host/ehci-mxs.c                  |    8 +-
>  22 files changed, 529 insertions(+), 529 deletions(-)
[...]

Given that the PSU regs for example have completely different register map and 
bit maps in the registers itself, I'd be careful with the renaming.

Uh oh well, I guess it has to be done like that though.

Best regards,
Marek Vasut

  reply	other threads:[~2012-07-29  1:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-28 22:50 [U-Boot] [RFC PATCH 0/5] Rework for mxs SoC family support Otavio Salvador
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 1/5] mxs: reorganize source directory for easy sharing of code in i.MXS SoCs Otavio Salvador
2012-08-04 22:33   ` Otavio Salvador
2012-08-04 22:40   ` Marek Vasut
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix Otavio Salvador
2012-07-29  1:33   ` Marek Vasut [this message]
2012-07-29  7:00     ` Stefano Babic
2012-07-29  7:06       ` Marek Vasut
2012-07-29 12:43       ` Otavio Salvador
2012-07-29 12:55         ` Marek Vasut
2012-07-29 13:01           ` Otavio Salvador
2012-07-29 13:10             ` Marek Vasut
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 3/5] mxs: prefix register structs " Otavio Salvador
2012-08-04 22:34   ` Otavio Salvador
2012-08-04 22:40   ` Marek Vasut
2012-08-04 22:44     ` Otavio Salvador
2012-08-04 22:46       ` Marek Vasut
2012-08-05  6:46         ` Stefano Babic
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 4/5] mxs: Reowork SPL to use 'mxs' prefix for methods Otavio Salvador
2012-08-04 22:35   ` Otavio Salvador
2012-07-28 22:50 ` [U-Boot] [RFC PATCH 5/5] mxs: rename mx28.c to mxs.c as it is common to i.MX233 and i.MX28 SoCs Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207290333.02699.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox