From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [V3 09/15] arm1176: Fixed No relocation.
Date: Sun, 29 Jul 2012 12:12:18 +0200 [thread overview]
Message-ID: <20120729121218.3a05e6bb@lilith> (raw)
In-Reply-To: <1343468148-26595-10-git-send-email-bocui107@gmail.com>
Hi Zhong,
On Sat, 28 Jul 2012 17:35:42 +0800, Zhong Hongbo <bocui107@gmail.com> wrote:
> From: Zhong Hongbo <bocui107@gmail.com>
>
> When It do not need to relocat for u-boot,
> the offset(r9) of relocation should be set zero.
>
> Signed-off-by: Zhong Hongbo <bocui107@gmail.com>
> ---
> Change for V3:
> - Replace mov with moveq.
> Change for V2:
> - Seprate some code.
> ---
> arch/arm/cpu/arm1176/start.S | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S
> index 761b7fe..dd1b73b 100644
> --- a/arch/arm/cpu/arm1176/start.S
> +++ b/arch/arm/cpu/arm1176/start.S
> @@ -252,6 +252,7 @@ stack_setup:
>
> adr r0, _start
> cmp r0, r6
> + moveq r9, #0
> beq clear_bss /* skip relocation */
> mov r1, r6 /* r1 <- scratch for copy_loop */
> ldr r3, _bss_start_ofs
I suspect this goes for other ARM arches as well, does it not?
Please fix globally.
(considering this is the second time in a small period where such a global
fixing is needed, I'll have a look at commonalizing start.S files across
all ARM arches if possible and submit a patch for the coming window -- unless
someone else has this ongoing already)
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-07-29 10:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 9:35 [U-Boot] V3: S3c64xx: Switch all I/O to use readl/writel functio and Clear variable Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 01/15] smdk6400: Move smdk6400 board from Makefile to boards.cfg Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 02/15] S3C64XX: Switch to use readl/writel to operate nand flash Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 03/15] S3C64XX: Use readl/writel to operate uart Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 04/15] S3C64XX: add pwm for s3c64xx support Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 05/15] S3C64XX: reference s5p cpu time system for s3c64xx timer Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 06/15] S3C64xx: mov cpu_init.S to the board directory Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 07/15] S3C6400: Delete nand_spl for S3C6400 Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 08/15] S3C6400: Adopt SPL framwork to support spl for nand flash Zhong Hongbo
2012-08-10 23:30 ` Scott Wood
2012-08-14 14:15 ` Zhong Hongbo
2012-08-14 16:02 ` Scott Wood
2012-07-28 9:35 ` [U-Boot] [V3 09/15] arm1176: Fixed No relocation Zhong Hongbo
2012-07-29 10:12 ` Albert ARIBAUD [this message]
2012-07-29 10:50 ` Zhong Hongbo
2012-07-29 11:09 ` Zhong Hongbo
2012-08-01 14:20 ` Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 10/15] S3C64XX: Change SROM init to use read/write operation Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 11/15] S3C64XX: Switch to use read/writel to operation clock system Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 12/15] S3c64xx: clear GPIO, Interrupt, Watchdog variable Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 13/15] S3C6400: clear memory init variable Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 14/15] S3C64XX: Move s3c6400.h to cpu.h to support s3c6410 board Zhong Hongbo
2012-07-28 9:35 ` [U-Boot] [V3 15/15] S3C6400: Remove the unused variable for S3C6400 Zhong Hongbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729121218.3a05e6bb@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox