[U-Boot] [PATCH] hawkboard: Fix SPL Nand driver misconfiguration

[U-Boot] [PATCH] hawkboard: Fix SPL Nand driver misconfiguration

[Linu Cherian]

Hawkboard was using the wrong nand_read_page version for SPL image.
As a side effect, the u-boot image loaded by the SPL from nand
was getting corrupted.

Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
algorithm for SPL.

Signed-off-by: Linu Cherian <linucherian@gmail.com>
---
 include/configs/hawkboard.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/configs/hawkboard.h b/include/configs/hawkboard.h
index c6e8859..c6e9ce5 100644
--- a/include/configs/hawkboard.h
+++ b/include/configs/hawkboard.h
@@ -123,6 +123,7 @@
 #define CONFIG_SYS_NAND_USE_FLASH_BBT
 #define CONFIG_NAND_DAVINCI
 #define CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST
+#define CONFIG_SYS_NAND_HW_ECC_OOBFIRST /* SPL nand driver configuration */
 #define CFG_DAVINCI_STD_NAND_LAYOUT
 #define CONFIG_SYS_NAND_CS		3
 #define CONFIG_SYS_NAND_PAGE_2K
-- 
1.7.1

[U-Boot] [PATCH] hawkboard: Fix SPL Nand driver misconfiguration

[Sughosh Ganu]

On Fri Jul 27, 2012 at 01:51:53PM +0530, Linu Cherian wrote:
> Hawkboard was using the wrong nand_read_page version for SPL image.
> As a side effect, the u-boot image loaded by the SPL from nand
> was getting corrupted.
> 
> Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> algorithm for SPL.
> 
> Signed-off-by: Linu Cherian <linucherian@gmail.com>

Acked-by: Sughosh Ganu <urwithsughosh@gmail.com>

Tom, since this is a bug fix, can this go to the 2012.07 release.

-sughosh

[U-Boot] [PATCH] hawkboard: Fix SPL Nand driver misconfiguration

[Sughosh Ganu]

hi Wolfgang,
On Fri Jul 27, 2012 at 03:16:15PM +0530, Sughosh Ganu wrote:
> On Fri Jul 27, 2012 at 01:51:53PM +0530, Linu Cherian wrote:
> > Hawkboard was using the wrong nand_read_page version for SPL image.
> > As a side effect, the u-boot image loaded by the SPL from nand
> > was getting corrupted.
> > 
> > Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> > algorithm for SPL.
> > 
> > Signed-off-by: Linu Cherian <linucherian@gmail.com>
> 
> Acked-by: Sughosh Ganu <urwithsughosh@gmail.com>
> 
> Tom, since this is a bug fix, can this go to the 2012.07 release.

Did not get any response from Tom, so if it's not too late, can this
patch be applied to the master for the 2012.07 release. It is a
bugfix.

-sughosh

[U-Boot] [PATCH] hawkboard: Fix SPL Nand driver misconfiguration

[Tom Rini]

On Fri, Jul 27, 2012 at 03:16:15PM +0530, Sughosh Ganu wrote:
> On Fri Jul 27, 2012 at 01:51:53PM +0530, Linu Cherian wrote:
> > Hawkboard was using the wrong nand_read_page version for SPL image.
> > As a side effect, the u-boot image loaded by the SPL from nand
> > was getting corrupted.
> > 
> > Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> > algorithm for SPL.
> > 
> > Signed-off-by: Linu Cherian <linucherian@gmail.com>
> 
> Acked-by: Sughosh Ganu <urwithsughosh@gmail.com>
> 
> Tom, since this is a bug fix, can this go to the 2012.07 release.

Acked-by: Tom Rini <trini@ti.com>

Wolfgang, please take this for the release, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120730/71141df4/attachment.pgp>

[U-Boot] [PATCH] hawkboard: Fix SPL Nand driver misconfiguration

[Wolfgang Denk]

Dear Linu Cherian,

In message <1343377313-30301-1-git-send-email-linucherian@gmail.com> you wrote:
> Hawkboard was using the wrong nand_read_page version for SPL image.
> As a side effect, the u-boot image loaded by the SPL from nand
> was getting corrupted.
> 
> Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> algorithm for SPL.
> 
> Signed-off-by: Linu Cherian <linucherian@gmail.com>
> ---
>  include/configs/hawkboard.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton