From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 30 Jul 2012 11:20:40 +0200 Subject: [U-Boot] [U-Boot-DM] dwc_ahsata vs ahci In-Reply-To: <5D7CDCE0FBAD974596A672304F004DC41554A7@039-SN2MPN1-011.039d.mgd.msft.net> References: <1976917.If85v0vZIe@merom> <5014DE6C.5070109@denx.de> <5D7CDCE0FBAD974596A672304F004DC41554A7@039-SN2MPN1-011.039d.mgd.msft.net> Message-ID: <201207301120.40216.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lv Terry-R65388, > Hi Pavel, > > The ahci.c is a ahci driver using pci interface, while dwc_asata is not. > > u-boot don't have a pure ahci driver now, thus we have to reuse some ahci > parts from ahci.c in dwc_asata.c. Ok, I think we can unify that eventually. > Thanks~~ > > Yours > Terry > > -----Original Message----- > From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On > Behalf Of Stefano Babic Sent: 2012?7?29? 14:56 > To: Pavel Herrmann > Cc: u-boot at lists.denx.de; u-boot-dm at lists.denx.de > Subject: Re: [U-Boot] dwc_ahsata vs ahci > > On 28/07/2012 15:44, Pavel Herrmann wrote: > > Hi, > > Hi Pavel, > > > While working on the DM project, I found out that there are two > > implementations of AHCI drivers - one in block/ahci.c, one in > > block/dwc_ahsata.c > > ooopppss ! > > > what is the difference between them (apart from the obvious, ahci.c > > exposes SCSI API, dwc_ahsata exposes SATA API)? are there any problems > > that would prevent me from merging them? > > No, there are not evident reasons ! > > dwc_asata was inserted to add SATA support for Freescale MX5 family, and I > missed that a similar driver was already in u-boot. dwc_ahsata was ported > from Freescale's u-boot, and linked only for MX5 / MX6 SOCs. I think it is > a very good idea to merge the two drivers (dwc_ahsata seems an updated > version of the original driver), thanks to note this ! > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de > ===================================================================== > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > > > _______________________________________________ > U-Boot-DM mailing list > U-Boot-DM at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot-dm Best regards, Marek Vasut