From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] usb_test_unit_ready called every block read - performance
Date: Tue, 31 Jul 2012 00:54:12 +0200 [thread overview]
Message-ID: <201207310054.12371.marex@denx.de> (raw)
In-Reply-To: <CACjqNxs704zyQ9O3oNKnorokWHaCsU_sJqxRZiK8b8UEs8VJ4A@mail.gmail.com>
Dear Jim Shimer,
> While tuning ext2load, we found that usb_test_unit_ready was being called
> every block read. We compared the usb block storage to the scsi block
> storage cmd_scsi.c, and found that the scsi device was only calling its
> scsi_setup_test_unit_ready() during scsi_can. It appears that
> usb_test_unit_ready() really only needs to be called once during
> usb_stor_scan(), via usb_stor_get_info(). Is there a particular reason
> usb_test_unit_ready is called for every block read, or do you think its ok
> to only call during usb_stor_scan()? We're finding this speeds up ext2load
> quite a bit.
Could it be because the USB is actually quite slower than SCSI and the device
might get congested? It seems the code was there ever since (I can't seem to
find the origin of it) and we might actually want to try if this doesn't break
some usb 1.x things.
> Regards,
> Jim
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-30 22:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 19:18 [U-Boot] usb_test_unit_ready called every block read - performance Jim Shimer
2012-07-30 22:54 ` Marek Vasut [this message]
2012-07-30 23:35 ` Jim Shimer
2012-07-30 23:41 ` Marek Vasut
2012-07-31 2:17 ` Jim Shimer
2012-07-31 4:43 ` Wolfgang Denk
2012-08-14 17:50 ` Marek Vasut
2012-08-14 17:57 ` Steve Heckman
2012-08-15 14:04 ` Jim Shimer
2012-08-12 23:54 ` Marek Vasut
2012-08-14 13:55 ` Steve Heckman
2012-08-14 17:48 ` Marek Vasut
2012-08-15 14:19 ` Jim Shimer
2012-08-15 16:45 ` Steve Heckman
2012-08-18 23:17 ` Marek Vasut
2012-08-18 23:16 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207310054.12371.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox