public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function
Date: Tue, 31 Jul 2012 10:06:40 -0400	[thread overview]
Message-ID: <201207311006.41037.vapier@gentoo.org> (raw)
In-Reply-To: <201207311555.55648.marex@denx.de>

On Tuesday 31 July 2012 09:55:55 Marek Vasut wrote:
> Dear Mike Frysinger,
> > On Saturday 28 July 2012 15:57:33 Wolfgang Denk wrote:
> > > Marek Vasut wrote:
> > > > > >  include/common.h |    7 +++++++
> > > > > >  1 file changed, 7 insertions(+)
> > > > > 
> > > > > We have similar things already, and we don't add dead code - you
> > > > > add a macro without users here.
> > > > 
> > > > It's used in 2/2 ... what macro do you have in mind ?
> > > 
> > > Then add it with the patch that uses it.
> > > 
> > > As for existing use, see for example
> > 
> > there's also MK_STR() and XMK_STR().
> 
> Grunt ... how do you find those? Or is it that you just happened to run
> over them?

these are the ones we use in Blackfin boards that i happened to stumble across 
when reading some common code

> > would be good to import
> > linux/stringify.h (rather than adding these macros to common.h) and
> > converting all consumers over to that.
> 
> I wonder, what's the gain?

one less way we're different from linux for importing code
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120731/42e5ba39/attachment.pgp>

  reply	other threads:[~2012-07-31 14:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-28 13:47 [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function Marek Vasut
2012-07-28 13:47 ` [U-Boot] [RFC] [PATCH 2/2] crazy: Sort u_boot_cmd at runtime Marek Vasut
2012-07-28 17:46   ` Wolfgang Denk
2012-07-28 18:39     ` Marek Vasut
2012-07-28 19:53       ` Wolfgang Denk
2012-07-28 20:54         ` Marek Vasut
2012-07-28 19:36 ` [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function Wolfgang Denk
2012-07-28 19:39   ` Marek Vasut
2012-07-28 19:57     ` Wolfgang Denk
2012-07-28 20:59       ` Marek Vasut
2012-07-31  8:01       ` Mike Frysinger
2012-07-31 13:55         ` Marek Vasut
2012-07-31 14:06           ` Mike Frysinger [this message]
2012-07-31 14:08             ` Marek Vasut
2012-07-31 14:16               ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207311006.41037.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox