[U-Boot] [RFC] [PATCH 2/2] crazy: Sort u_boot_cmd at runtime

Wolfgang Denk
2012-07-28T17:46:29Z

Dear Marek Vasut,

In message <1343483279-11572-2-git-send-email-marex@denx.de> you wrote:
> This shall eliminate the need for bubblesorting of commands at runtime.
> Every command definition structure is now put into it's own subsection
> of section .u_boot_cmd, that is .u_boot_cmd.<name> . These are then put
> into .u_boot_cmd by linker and lastly, linker uses SORT() over these
> subsections to make proper order on them. This shall eliminate some
> runtime overhead.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Mike Frysinger <vapier@gentoo.org>
> ---
> arch/arm/cpu/u-boot.lds | 2 +-
> common/cmd_help.c | 2 +-
> include/command.h | 9 ++++++---
> 3 files changed, 8 insertions(+), 5 deletions(-)

Seems incomplete in several aspects:

1) what about all the non-ARM architecures and the board specific
linker scripts?

2) what about removing the sort code?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Men of peace usually are [brave].
-- Spock, "The Savage Curtain", stardate 5906.5