From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 31 Jul 2012 16:08:51 +0200
Subject: [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function
In-Reply-To: <201207311006.41037.vapier@gentoo.org>
References: <1343483279-11572-1-git-send-email-marex@denx.de>
	<201207311555.55648.marex@denx.de>
	<201207311006.41037.vapier@gentoo.org>
Message-ID: <201207311608.51417.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Mike Frysinger,

> On Tuesday 31 July 2012 09:55:55 Marek Vasut wrote:
> > Dear Mike Frysinger,
> > 
> > > On Saturday 28 July 2012 15:57:33 Wolfgang Denk wrote:
> > > > Marek Vasut wrote:
> > > > > > >  include/common.h |    7 +++++++
> > > > > > >  1 file changed, 7 insertions(+)
> > > > > > 
> > > > > > We have similar things already, and we don't add dead code - you
> > > > > > add a macro without users here.
> > > > > 
> > > > > It's used in 2/2 ... what macro do you have in mind ?
> > > > 
> > > > Then add it with the patch that uses it.
> > > > 
> > > > As for existing use, see for example
> > > 
> > > there's also MK_STR() and XMK_STR().
> > 
> > Grunt ... how do you find those? Or is it that you just happened to run
> > over them?
> 
> these are the ones we use in Blackfin boards that i happened to stumble
> across when reading some common code

Ugh ... makes you feel like Indy, discovering gems in crazy places and fighting 
hordes of evil code ...

> > > would be good to import
> > > linux/stringify.h (rather than adding these macros to common.h) and
> > > converting all consumers over to that.
> > 
> > I wonder, what's the gain?
> 
> one less way we're different from linux for importing code

Not that that macro is ever gonna change, but so be it.

> -mike

Best regards,
Marek Vasut