From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7 V3] SPI: Add SPI Driver for EXYNOS.
Date: Wed, 1 Aug 2012 12:32:00 -0400 [thread overview]
Message-ID: <201208011232.01463.vapier@gentoo.org> (raw)
In-Reply-To: <1343813612-1587-6-git-send-email-rajeshwari.s@samsung.com>
On Wednesday 01 August 2012 05:33:30 Rajeshwari Shinde wrote:
> --- /dev/null
> +++ b/drivers/spi/exynos_spi.c
>
> +DECLARE_GLOBAL_DATA_PTR;
i don't think you use this, so delete
> +void spi_flush_fifo(struct spi_slave *slave)
static
> +void spi_init(void)
> +{
> ...
> + for (i = 0; i < EXYNOS5_SPI_NUM_CONTROLLERS; i++) {
> ...
> + bus_count++;
why bother with a static bus_count ? just use the existing define.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120801/66f0cd59/attachment.pgp>
next prev parent reply other threads:[~2012-08-01 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 9:33 [U-Boot] [PATCH 0/7 V3] EXYNOS5: Enable SPI support Rajeshwari Shinde
2012-08-01 9:33 ` [U-Boot] [PATCH 1/7 V3] EXYNOS5: Add pinmux support for SPI Rajeshwari Shinde
2012-08-01 9:33 ` [U-Boot] [PATCH 2/7 V3] SPI: Add W25Q32 to Winbond SPI flash table Rajeshwari Shinde
2012-08-01 16:27 ` Mike Frysinger
2012-08-01 9:33 ` [U-Boot] [PATCH 3/7 V3] EXYNOS: Add clock for SPI Rajeshwari Shinde
2012-08-01 9:33 ` [U-Boot] [PATCH 4/7 V3] EXYNOS5: Add base address " Rajeshwari Shinde
2012-08-01 9:33 ` [U-Boot] [PATCH 5/7 V3] SPI: Add SPI Driver for EXYNOS Rajeshwari Shinde
2012-08-01 16:32 ` Mike Frysinger [this message]
2012-08-01 9:33 ` [U-Boot] [PATCH 6/7 V3] EXYNOS5: Enable SPI Rajeshwari Shinde
2012-08-01 9:33 ` [U-Boot] [PATCH 7/7 V3] Enable SPI booting Rajeshwari Shinde
2012-08-01 16:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208011232.01463.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox